Stop pointing the docs at another fork's site - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
homepageinpackage.jsonand every demo link in the README pointed atreact-spring-bottom-sheet.nipesolutions.com. That domain does not serve this fork: itbelongs to NIPE-Solutions/react-spring-bottom-sheet, a different fork of the same
original, with its own rewritten docs.
Measured on the live HTML: zero occurrences of
Guiw5, ofguiw5-bottom-sheet, or ofany heading from this repo's fixtures, against 24 occurrences of
react-spring-bottom-sheetand links to both stipsan's and NIPE-Solutions' repos.The practical effect was that npm's package page sent people to another project's
website, and the six demo links all 404'd, because that site has no
/fixtures/*routes. This repo's own build produces them fine.
Changes
homepagenow points at this repository, which is what npm links to.local copy in
public/. Removed rather than left embedding another project's asset.View demo codelink under each onealready points into this repo, so nothing is lost.
Demosheading explains how to run them locally, including the network URL Nextprints, which is how you open a fixture on a phone.
Hosting this fork's docs and pointing everything back at a real URL is the better fix,
but it needs a Vercel project on the owner's account. This removes the wrong links in
the meantime.
Test plan
npm test: lint, 32 tests, library build, docs buildREADME.mdorpackage.json