Repository navigation
Drive water ring and bar preview animations from FrameAnimation - #91
Open
hugorolimf wants to merge 1 commit into
Open
hugorolimf wants to merge 1 commit into
hugorolimf wants to merge 1 commit into
Conversation
The CPU, battery and temperature water rings redrew from a 50 ms Timer (20 fps) and the bar gap-animation preview from a 33 ms Timer (30 fps), so they looked choppy on high-refresh displays. Use FrameAnimation so they follow the display refresh rate. The wave keeps its 20 steps/s speed and the percent easing keeps its 25% per 50 ms rate, both scaled by the real frame time (clamped to 100 ms), so the visuals match the previous timing on any refresh rate. waveFrame becomes a real so the phase advances smoothly. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a 144 Hz display (Omarchy 4.0.6, Quickshell, Hyprland 0.56.2) some Shibumi animations look like they run at 20-30 Hz. An isolated Quickshell
PanelWindowwith aFrameAnimationcounter measured 144 fps on both outputs, so the limit is in the Shibumi code, not the host:shared/presentation/WaterRing.qml(CPU, battery and temperature panels) redraws from a 50 msTimer, i.e. 20 fps.hancore.shibumi.control-center/ActiveBarSettingsPage.qmlrepaints the gap-animation preview from a 33 msTimer, i.e. 30 fps.Change
Both timers are replaced by
FrameAnimation, so they follow the display refresh rate.waveFrameis now areal(also inBatteryRing.qml) so the phase advances smoothly instead of in 1/72 steps.Date.now(), so only the repaint trigger changes.WaterRing.qmlis changed and the three vendored copies are synchronized withscripts/sync-shared.sh --write.Not changed: the 60 fps Cava input of the media spectrum, which is bounded by the audio source rather than a timer.
Affected plugins
hancore.shibumi.cpu,hancore.shibumi.battery,hancore.shibumi.temperature,hancore.shibumi.control-center.Checks run
git diff --check./scripts/sync-shared.sh --checktests/power-plugins-regression.shtests/control-center-regression.shThe full
tests/contract-regression.shwas not run.Live UI evidence
Not captured. The change was not rendered on a live Wayland session, so the visual result at 144 Hz and the extra CPU cost of redrawing the Canvas at that rate are unverified. To verify: open the CPU, battery or temperature panel with water enabled, and open Bars -> Gap Animations in the control center, on a high-refresh output. Multi-output was not tested.
🤖 Generated with Claude Code