Skip to content

在修改游戏版本时清除已选的模组加载器 #6475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CiiLu wants to merge 6 commits into
base: main
Choose a base branch
from
+3 −16
Open

在修改游戏版本时清除已选的模组加载器 #6475

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b42213d
(27) 约晚春同祭天后
CiiLu Jul 22, 2026
7a4efc9
Merge branch 'main' into s
CiiLu Jul 30, 2026
d5e4ec5
(41) 迎或饯 狂与谦 都合衷
CiiLu Jul 30, 2026
a918498
Merge remote-tracking branch 'upstream/main' into s
Glavo Aug 21, 2026
02316d1
<7> 诗中人 苍茫云海间
CiiLu Sep 5, 2026
f67010f
<8> 数圆缺 风雨杳如年
CiiLu Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions HMCL/src/main/java/org/jackhuang/hmcl/ui/download/AdditionalInstallersPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public AdditionalInstallersPage(HMCLGameInstance instance, String gameVersion, W
});
}

installable.bind(Bindings.createBooleanBinding(() -> compatible.get() && txtName.validate(), txtName.textProperty(), compatible));
installable.bind(Bindings.createBooleanBinding(() -> txtName.validate(), txtName.textProperty()));
}

@Override
Expand All @@ -80,27 +80,14 @@ private String getVersion(GameComponentType type) {

@Override
protected void reload() {
boolean gameVersionChanged = !instance.getVersion().toString().equals(getVersion(GameComponentType.GAME));
boolean compatible = true;

for (InstallerItem component : group.getComponents()) {
GameComponentType componentType = component.getComponentType();
String version = instance.getComponentVersion(component.getComponentType());
String libraryVersion = Lang.requireNonNullElse(getVersion(componentType), version);
boolean alreadyInstalled = version != null && !(controller.getSettings().get(componentType.getPatchId()) instanceof UpdateInstallerWizardProvider.RemoveComponentAction);
if (component.getComponentType() != GameComponentType.GAME && gameVersionChanged && getVersion(componentType) == null && alreadyInstalled) {
// For third-party libraries, if game version is being changed, and the library is not being reinstalled,
// warns the user that we should update the library.
component.versionProperty().set(new InstallerItem.InstalledState(libraryVersion, false, true));
compatible = false;
} else if (alreadyInstalled || getVersion(componentType) != null) {
component.versionProperty().set(new InstallerItem.InstalledState(libraryVersion, false, false));
if (controller.getSettings().containsKey(componentType.getPatchId())) {
component.versionProperty().set(new InstallerItem.InstalledState(getVersion(componentType), false, false));
Comment on lines +85 to +86

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Treat removal actions as unselected components

When a user selects a loader, clicks its remove button, and then tries to select an incompatible alternative, the setting still contains a RemoveVersionAction, so this branch renders the removed loader as InstalledState(null, ...). InstallerItemGroup consequently keeps alternatives such as Forge and Fabric mutually incompatible and prevents the replacement from being selected; it also continues showing the removed loader as installed. Check for a selected RemoteVersion rather than mere key presence so removal actions render as unselected.

Useful? React with 👍 / 👎.

} else {
component.versionProperty().set(null);
}
}

this.compatible.set(compatible);
}

@Override
Expand Down