简化 FabricLike 加载器相关代码 - #6817
Open
CiiLu wants to merge 4 commits into
Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| this.legacyFabric = new LegacyFabricVersionList(this); | ||
| this.legacyFabricApi = new LegacyFabricAPIVersionList(this); | ||
| this.legacyFabricApi = new ModrinthComponentVersionList(this, GameComponentType.LEGACY_FABRIC_API, "9CJED7xi"); | ||
| ; |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.coding.EmptyStatementCheck]
Empty statement.
|
|
||
| private static String normalizeVersion(String version) { | ||
|
|
||
| @Override |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck]
'METHOD_DEF' has more than 1 empty lines before.
| public JsonObject getLauncherMeta() { | ||
| return launcherMeta; | ||
| } | ||
| protected String getMavenRepositoryByGroup(String maven) { |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck]
'METHOD_DEF' has more than 1 empty lines before.
| this.quiltApi = new ModrinthComponentVersionList(this, GameComponentType.QUILT_API, "qvIfYCYJ"); | ||
| this.legacyFabric = new LegacyFabricVersionList(this); | ||
| this.legacyFabricApi = new LegacyFabricAPIVersionList(this); | ||
| this.legacyFabricApi = new ModrinthComponentVersionList(this, GameComponentType.LEGACY_FABRIC_API, "9CJED7xi");; |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.coding.EmptyStatementCheck]
Empty statement.
| this.legacyFabric = new LegacyFabricVersionList(this); | ||
| this.legacyFabricApi = new LegacyFabricAPIVersionList(this); | ||
| this.legacyFabricApi = new ModrinthComponentVersionList(this, GameComponentType.LEGACY_FABRIC_API, "9CJED7xi"); | ||
| ; |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.coding.EmptyStatementCheck]
Empty statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
目前很多代码被复制了 Fabric、Legacy Fabric、Quilt 三份，改动的时候比较不方便且如果要添加新加载器（如 Ornithe 还得再复制一份）