优化启动器崩溃处理机制 - #6825
Open
CiiLu wants to merge 6 commits into
Open
Conversation
CiiLu
commented
Sep 6, 2026
CiiLu
commented
Contributor
- 移除目前的崩溃分析机制。目前大部分规则已经过期，且正确率极低。且目前如果分析出了原因只会显示仅有原因的 Alert。在崩溃群或用户群遇到这种还得引导用户使用命令行启动 hmcl 或手动寻找日志文件，交流成本极高。
- 在崩溃窗口添加导出启动器日志按钮
- 多次出现错误时在现有窗口追加内容，避免部分频繁处理的逻辑（如加载游戏版本）出错一次性出现一大堆崩溃窗口。
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| /** | ||
| * @author huangyuhui | ||
| */ | ||
| public class CrashWindow extends Stage { |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.design.FinalClassCheck]
Class CrashWindow should be declared as final.
| } | ||
|
|
||
|
|
||
| public void addCrashReport(CrashReport report) { |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck]
'METHOD_DEF' has more than 1 empty lines before.
|
|
||
|
|
||
|
|
||
| public static Path exportLogsAsZip() throws IOException { |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck]
'METHOD_DEF' has more than 1 empty lines before.
| } | ||
|
|
||
|
|
||
| private static String getEntryName(Set<String> entryNames, String name) { |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck]
'METHOD_DEF' has more than 1 empty lines before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.