Skip to content

Change label to "inc. soft navs" #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tunetheweb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change label to "inc. soft navs" #1375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 34 additions & 34 deletions config/techreport.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,19 +333,19 @@
"value": "TTFB"
},
{
"label": "Good Core Web Vitals (with soft navs)",
"label": "Good Core Web Vitals (inc. soft navs)",

@max-ostapenko max-ostapenko Oct 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking to expand into incl., but I understand the confusion is about defining its additive definition.

+ version seems most straightforward.

Suggested change
"label": "Good Core Web Vitals (inc. soft navs)",
"label": "Good Core Web Vitals (+ soft navs)",

WDYT?

"value": "overall_sn"
},
{
"label": "Good LCP (with soft navs)",
"label": "Good LCP (inc. soft navs)",
"value": "LCP_sn"
},
{
"label": "Good INP (with soft navs)",
"label": "Good INP (inc. soft navs)",
"value": "INP_sn"
},
{
"label": "Good CLS (with soft navs)",
"label": "Good CLS (inc. soft navs)",
"value": "CLS_sn"
}
]
Expand Down Expand Up @@ -763,10 +763,10 @@
"CLS": "Good CLS",
"FCP": "Good FCP",
"TTFB": "Good TTFB",
"overall_sn": "Good Core Web Vitals (with soft navs)",
"LCP_sn": "Good LCP (with soft navs)",
"INP_sn": "Good INP (with soft navs)",
"CLS_sn": "Good CLS (with soft navs)"
"overall_sn": "Good Core Web Vitals (inc. soft navs)",
"LCP_sn": "Good LCP (inc. soft navs)",
"INP_sn": "Good INP (inc. soft navs)",
"CLS_sn": "Good CLS (inc. soft navs)"
}
},
"cwv_distribution": {
Expand All @@ -783,11 +783,11 @@
"step": 100
},
"LCP_sn": {
"label": "LCP (soft navs)",
"label": "LCP (inc. soft navs)",
"bucketField": "loading_bucket",
"originsField": "lcp_sn_origins",
"unit": "ms",
"axis_label": "LCP with soft navs (ms)",
"axis_label": "LCP inc. soft navs (ms)",
"step": 100
},
"FCP": {
Expand All @@ -814,11 +814,11 @@
"step": 25
},
"INP_sn": {
"label": "INP (soft navs)",
"label": "INP (inc. soft navs)",
"bucketField": "inp_bucket",
"originsField": "inp_sn_origins",
"unit": "ms",
"axis_label": "INP with soft navs (ms)",
"axis_label": "INP inc. soft navs (ms)",
"step": 25
},
"CLS": {
Expand All @@ -830,11 +830,11 @@
"step": 0.05
},
"CLS_sn": {
"label": "CLS (soft navs)",
"label": "CLS (inc. soft navs)",
"bucketField": "cls_bucket",
"originsField": "cls_sn_origins",
"unit": "",
"axis_label": "CLS with soft navs",
"axis_label": "CLS inc. soft navs",
"step": 0.05
}
},
Expand Down Expand Up @@ -991,19 +991,19 @@
"value": "TTFB"
},
{
"label": "Good Core Web Vitals (with soft navs)",
"label": "Good Core Web Vitals (inc. soft navs)",
"value": "overall_sn"
},
{
"label": "Good LCP (with soft navs)",
"label": "Good LCP (inc. soft navs)",
"value": "LCP_sn"
},
{
"label": "Good INP (with soft navs)",
"label": "Good INP (inc. soft navs)",
"value": "INP_sn"
},
{
"label": "Good CLS (with soft navs)",
"label": "Good CLS (inc. soft navs)",
"value": "CLS_sn"
}
]
Expand Down Expand Up @@ -1509,23 +1509,23 @@
"description": "TTFB is a metric that measures the time between the request for a resource and when the first byte of a response begins to arrive. A good TTFB is less than or equal to 800ms."
},
"overall_sn": {
"label": "Good Core Web Vitals (with soft navs)",
"title": "Good Core Web Vitals (with soft navs)",
"label": "Good Core Web Vitals (inc. soft navs)",
"title": "Good Core Web Vitals (inc. soft navs)",
"description": "The percentage of origins passing all three Core Web Vitals (LCP, INP, CLS) with a good experience, accounting for soft navigations in single-page applications. Note that if an origin is missing INP data, it's assessed based on the performance of the remaining metrics."
},
"LCP_sn": {
"label": "Good LCP (with soft navs)",
"title": "Good Largest Contentful Paint (with soft navs)",
"label": "Good LCP (inc. soft navs)",
"title": "Good Largest Contentful Paint (inc. soft navs)",
"description": "Largest Contentful Paint including soft navigations measures perceived load speed across both hard page loads and subsequent in-app soft navigations. Good experiences are less than or equal to 2.5 seconds."
},
"INP_sn": {
"label": "Good INP (with soft navs)",
"title": "Good Interaction to Next Paint (with soft navs)",
"label": "Good INP (inc. soft navs)",
"title": "Good Interaction to Next Paint (inc. soft navs)",
"description": "Interaction to Next Paint including soft navigations assesses responsiveness across user interactions within the lifespan of a visit, including interactions occurring during soft navigations. A good experience is less than or equal to 200ms."
},
"CLS_sn": {
"label": "Good CLS (with soft navs)",
"title": "Good Cumulative Layout Shift (with soft navs)",
"label": "Good CLS (inc. soft navs)",
"title": "Good Cumulative Layout Shift (inc. soft navs)",
"description": "Cumulative Layout Shift including soft navigations measures visual stability across both initial loads and subsequent soft navigation page changes. Sites should strive to have a CLS of 0.1 or less for at least 75% of page visits."
}
},
Expand Down Expand Up @@ -1578,21 +1578,21 @@
"origins_with_good_fcp": "Having good FCP",
"origins_with_good_inp": "Having good INP",
"origins_with_good_ttfb": "Having good TTFB",
"origins_with_good_cwv_sn": "Having good Core Web Vitals (with soft navs)",
"origins_with_good_cls_sn": "Having good CLS (with soft navs)",
"origins_with_good_lcp_sn": "Having good LCP (with soft navs)",
"origins_with_good_inp_sn": "Having good INP (with soft navs)",
"origins_with_good_cwv_sn": "Having good Core Web Vitals (inc. soft navs)",
"origins_with_good_cls_sn": "Having good CLS (inc. soft navs)",
"origins_with_good_lcp_sn": "Having good LCP (inc. soft navs)",
"origins_with_good_inp_sn": "Having good INP (inc. soft navs)",

"pct_good_cwv": "% Good Core Web Vitals",
"pct_good_cls": "% Good CLS",
"pct_good_lcp": "% Good LCP",
"pct_good_fcp": "% Good FCP",
"pct_good_inp": "% Good INP",
"pct_good_ttfb": "% Good TTFB",
"pct_good_cwv_sn": "% Good Core Web Vitals (with soft navs)",
"pct_good_cls_sn": "% Good CLS (with soft navs)",
"pct_good_lcp_sn": "% Good LCP (with soft navs)",
"pct_good_inp_sn": "% Good INP (with soft navs)",
"pct_good_cwv_sn": "% Good Core Web Vitals (inc. soft navs)",
"pct_good_cls_sn": "% Good CLS (inc. soft navs)",
"pct_good_lcp_sn": "% Good LCP (inc. soft navs)",
"pct_good_inp_sn": "% Good INP (inc. soft navs)",

"median_lighthouse_score_accessibility": "Median accessibility",
"median_lighthouse_score_performance": "Median performance",
Expand Down
2 changes: 1 addition & 1 deletion src/js/techreport/geoBreakdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class GeoBreakdown {
if (this.selectedMetric === 'overall') {
slot.textContent = 'Core Web Vitals';
} else if (this.selectedMetric === 'overall_sn') {
slot.textContent = 'Core Web Vitals (soft navs)';
slot.textContent = 'Core Web Vitals (inc. soft navs)';
} else {
slot.textContent = this.pageConfig?.cwv_distribution?.metric_config?.[this.selectedMetric]?.label || this.selectedMetric;
}
Expand Down
4 changes: 2 additions & 2 deletions src/js/techreport/timeseries.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ class Timeseries {

const sortedData = this.extractPoints(app, endpoint, subcategory, client, metric);
const seriesColor = techColor || colors[index];
const seriesName = hardSubcategory ? `${tech} (soft navs)` : tech;
const seriesName = hardSubcategory ? `${tech} (inc. soft navs)` : tech;

series.push({
name: seriesName,
Expand Down Expand Up @@ -625,7 +625,7 @@ class Timeseries {
const colorLight = value.color;
const seriesColor = theme === "dark" ? colorDark : colorLight;

const seriesName = hardCategory ? `${value.name} (soft navs)` : value.name;
const seriesName = hardCategory ? `${value.name} (inc. soft navs)` : value.name;

// Push the configurations and formatted data to the series array
series.push({
Expand Down
Loading