Skip to content

Halyna R.#2

Open
halyna1995 wants to merge 5 commits into
HackYourAssignment:mainfrom
halyna1995:week4/halyna
Open

Halyna R.#2
halyna1995 wants to merge 5 commits into
HackYourAssignment:mainfrom
halyna1995:week4/halyna

Conversation

@halyna1995

Copy link
Copy Markdown

Complete week 4 pandas pipeline assignment

@lassebenni lassebenni closed this Jun 4, 2026
@lassebenni lassebenni reopened this Jun 4, 2026
@github-actions

This comment has been minimized.

@AgneseGi AgneseGi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tasks 1–6! The main issue is Task 7, where main.py sets GITHUB_USERNAME = "<halyna1995>", and upload_outputs treats that exact value as invalid, so the full pipeline will fail once it reaches upload

Comment thread src/ingest.py Outdated
Comment thread main.py Outdated
Comment thread src/ingest.py
Comment thread src/clean.py Outdated
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Refactor local_customer_summary variable and improve formatting for remote_customer_summary.
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown

📝 HackYourFuture auto grade

Assignment Score: 92 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 60
🧪 The auto grade is experimental and still being improved

Test Details
Week 4 autograder — MessyCorp Pandas pipeline
==============================================

Behavioural tests (L9): 8 / 16  (4 passed, 4 failed, 0 errors)
Static checks (L1-L7):  84 / 84
AI_ASSIST.md present:   true

Total: 92 / 100  ✅  (passing score: 60)

Functional test output:
FFFF....                                                                 [100%]
=================================== FAILURES ===================================
___________________ test_clean_sales_removes_negative_prices ___________________

    def test_clean_sales_removes_negative_prices():
>       from src.clean import clean_sales
E         File "/home/runner/work/c55-data-week-4/c55-data-week-4/assignment/src/clean.py", line 51
E           cleaned = cleaned.drop_duplicates(subset="transaction_id", keep="first")
E                                                                                   ^
E       IndentationError: unindent does not match any outer indentation level

.hyf/functional_tests.py:100: IndentationError
___________________ test_clean_sales_removes_zero_quantities ___________________

    def test_clean_sales_removes_zero_quantities():
>       from src.clean import clean_sales
E         File "/home/runner/work/c55-data-week-4/c55-data-week-4/assignment/src/clean.py", line 51
E           cleaned = cleaned.drop_duplicates(subset="transaction_id", keep="first")
E                                                                                   ^
E       IndentationError: unindent does not match any outer indentation level

.hyf/functional_tests.py:110: IndentationError
__________________ test_clean_sales_drops_nulls_and_bad_dates __________________

    def test_clean_sales_drops_nulls_and_bad_dates():
>       from src.clean import clean_sales
E         File "/home/runner/work/c55-data-week-4/c55-data-week-4/assignment/src/clean.py", line 51
E           cleaned = cleaned.drop_duplicates(subset="transaction_id", keep="first")
E                                                                                   ^
E       IndentationError: unindent does not match any outer indentation level

.hyf/functional_tests.py:120: IndentationError
_______________ test_clean_sales_dedupes_and_normalizes_strings ________________

    def test_clean_sales_dedupes_and_normalizes_strings():
>       from src.clean import clean_sales
E         File "/home/runner/work/c55-data-week-4/c55-data-week-4/assignment/src/clean.py", line 51
E           cleaned = cleaned.drop_duplicates(subset="transaction_id", keep="first")
E                                                                                   ^
E       IndentationError: unindent does not match any outer indentation level

.hyf/functional_tests.py:133: IndentationError
=========================== short test summary info ============================
FAILED .hyf/functional_tests.py::test_clean_sales_removes_negative_prices -   File "/home/runner/work/c55-data-week-4/c55-data-week-4/assignment/src/clean.py", line 51
    cleaned = cleaned.drop_duplicates(subset="transaction_id", keep="first")
                                                                            ^
IndentationError: unindent does not match any outer indentation level
FAILED .hyf/functional_tests.py::test_clean_sales_removes_zero_quantities -   File "/home/runner/work/c55-data-week-4/c55-data-week-4/assignment/src/clean.py", line 51
    cleaned = cleaned.drop_duplicates(subset="transaction_id", keep="first")
                                                                            ^
IndentationError: unindent does not match any outer indentation level
FAILED .hyf/functional_tests.py::test_clean_sales_drops_nulls_and_bad_dates -   File "/home/runner/work/c55-data-week-4/c55-data-week-4/assignment/src/clean.py", line 51
    cleaned = cleaned.drop_duplicates(subset="transaction_id", keep="first")
                                                                            ^
IndentationError: unindent does not match any outer indentation level
FAILED .hyf/functional_tests.py::test_clean_sales_dedupes_and_normalizes_strings -   File "/home/runner/work/c55-data-week-4/c55-data-week-4/assignment/src/clean.py", line 51
    cleaned = cleaned.drop_duplicates(subset="transaction_id", keep="first")
                                                                            ^
IndentationError: unindent does not match any outer indentation level
4 failed, 4 passed in 1.33s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants