Mohammed A#7
Open
mohammedalfakih-dev wants to merge 1 commit into
Open
Conversation
danlaudk
reviewed
Jul 8, 2026
| FROM vw_fact_trips AS t | ||
| GROUP BY | ||
| TO_CHAR(t.pickup_datetime, 'Day'), | ||
| EXTRACT(DOW FROM t.pickup_datetime) |
There was a problem hiding this comment.
this is dangerous doign group by two things when you only want one , even though you hope/expect the same thing. maybe you can still put both in the select, and if not there must be a cleaner alternative (even to use FIRST would be better)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completed the Week 9 NYC Taxi analytics assignment.
Changes
vw_fact_tripsandvw_dim_zones.data_dictionary.md,AI_ASSIST.md, and the borough-count screenshot.