fix autosuggestion bug - #987
Open
elseawhy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes #986
Previously splitting a word by inserting a space would cause
overlaps_withto return true since the split suffix technically overlapped the original byte range, which incorrectly triggers a restart. InRestart,auto-startedis hardcoded to true, this causes the auto suggestion menu to flash briefly if a restart is triggered when auto suggestion is disabled. The better and more correct way would be comparing the old and new state directly vianew_wuc.start == current_wuc.startTo address the hardcoded auto-suggest = true during restart, i added this
to extract the previous state ( whether it was auto started or not ), instead of hardcoding it to be true :)