Skip to content

fix(audio): Properly filter-out unavailable audio backends from UI#6705

Open
bassdr wants to merge 3 commits into
HarbourMasters:developfrom
bassdr:fix/remove-unavailable-audio-backend
Open

fix(audio): Properly filter-out unavailable audio backends from UI#6705
bassdr wants to merge 3 commits into
HarbourMasters:developfrom
bassdr:fix/remove-unavailable-audio-backend

Conversation

@bassdr

@bassdr bassdr commented Jun 9, 2026

Copy link
Copy Markdown

No description provided.

@Malkierian

Copy link
Copy Markdown
Contributor

What does this do that isn't already handled in LUS as it initializes mAvailableAudioBackends?

@serprex serprex requested a review from Malkierian June 9, 2026 03:55
@bassdr

bassdr commented Jun 9, 2026

Copy link
Copy Markdown
Author

You mean having the string on Lu's side? I can do that, I wanted to avoid depending on a pr in Lus for something as simple as that. I'll leave the pr here as is, while we see what LUS says.

@Malkierian

Copy link
Copy Markdown
Contributor

No, I mean that GetAvailableAudioBackends returns mAvailableAudioBackends, which has already been filtered for availability.

@bassdr

bassdr commented Jun 9, 2026

Copy link
Copy Markdown
Author

The list LUS gives us only has the enum, we have to provide a list of strings to dispa it in ImGui...

If we want to do that, we have to update LUS so it provides strings too, or I missed something, but I don't think so.

Here. I construct the map that imgui expects, based on the list LUS provides.

Comment thread soh/soh/SohGui/Menu.cpp Outdated
@Malkierian

Malkierian commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Ohhh, I didn't realize the strings weren't getting filtered. However, I'd prefer that the API name map be populated at startup like the renderer API name map is, rather than in the middle of a menu lambda. Unless someone can tell me why I thought calling UpdateWindowBackendObjects() in the WIDGET_VIDEO_BACKEND case was necessary.

@Malkierian

Copy link
Copy Markdown
Contributor

In other words, mirror the way availableWindowBackendsMap is handled as closely as possible, and I'll sign off on it.

@bassdr

bassdr commented Jun 9, 2026

Copy link
Copy Markdown
Author

Done, should be good to ship, I ran clang-format, compiled, tested, et al.

@bassdr bassdr force-pushed the fix/remove-unavailable-audio-backend branch from 6df602b to 6a83f0b Compare June 10, 2026 00:42
@bassdr bassdr changed the title Properly filter-out unavailable audio backends from UI fix(audio): Properly filter-out unavailable audio backends from UI Jun 11, 2026
@bassdr bassdr force-pushed the fix/remove-unavailable-audio-backend branch from 6a83f0b to 1912306 Compare June 11, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants