fix(audio): Properly filter-out unavailable audio backends from UI#6705
fix(audio): Properly filter-out unavailable audio backends from UI#6705bassdr wants to merge 3 commits into
Conversation
|
What does this do that isn't already handled in LUS as it initializes |
|
You mean having the string on Lu's side? I can do that, I wanted to avoid depending on a pr in Lus for something as simple as that. I'll leave the pr here as is, while we see what LUS says. |
|
No, I mean that GetAvailableAudioBackends returns mAvailableAudioBackends, which has already been filtered for availability. |
|
The list LUS gives us only has the enum, we have to provide a list of strings to dispa it in ImGui... If we want to do that, we have to update LUS so it provides strings too, or I missed something, but I don't think so. Here. I construct the map that imgui expects, based on the list LUS provides. |
|
Ohhh, I didn't realize the strings weren't getting filtered. However, I'd prefer that the API name map be populated at startup like the renderer API name map is, rather than in the middle of a menu lambda. Unless someone can tell me why I thought calling UpdateWindowBackendObjects() in the WIDGET_VIDEO_BACKEND case was necessary. |
|
In other words, mirror the way availableWindowBackendsMap is handled as closely as possible, and I'll sign off on it. |
|
Done, should be good to ship, I ran clang-format, compiled, tested, et al. |
6df602b to
6a83f0b
Compare
6a83f0b to
1912306
Compare
No description provided.