Skip to content

Give the side-scan a copilot it can reach from the chroot - #387

Merged
HardMax71 merged 2 commits into
mainfrom
fix-detection-sandbox
Aug 12, 2026
Merged

HardMax71 merged 2 commits into
mainfrom
fix-detection-sandbox

Conversation

@HardMax71

@HardMax71 HardMax71 commented Aug 12, 2026 •

Copy link
Copy Markdown
Owner

Every warning on #373 is one failure repeated: the compiled detection job hardcodes /usr/local/bin/copilot, which does not exist inside its chroot sandbox, so the scan dies at spawn in four milliseconds with zero output and the empty log reads as parse_error. The side-scan has never actually scanned anything since it was turned back on; the earlier model fix cured the previous cause, not this one.

Recompiling with gh-aw v0.86.2 points the detection harness at the runner-temp copilot the chroot can see. The deepseek model pins stay, the external-detector path with its unpinned latest-release fetch does not compile in, and the only moved action pin is gh-aw setup at its matching sha. The version is a pinned prerelease on purpose: stable v0.85.4 is what emits the dead path, and the 0.86 line carries the detection chroot fixes. The extension now installs from github/gh-aw, where the project moved; the old githubnext home stops at v0.85.4 and made upgrade report up to date.

This PR is its own testbed: the review lane runs these locks against it, so a green detection job here with no fresh parse_error comment on #373 is the fix demonstrated live.


Summary by cubic

Fixes the side-scan crash in the chroot by pointing the detector to a reachable Copilot binary. Also pins the commands dispatcher to the locked setup SHA to prevent tag drift.

  • Bug Fixes

    • Detector now uses the runner-temp copilot instead of /usr/local/bin/copilot, which wasn’t in the chroot.
    • Removed the external-detector build path and kept model pins for stable, reproducible runs.
  • Dependencies

    • Updated and pinned github/gh-aw-actions/setup to v0.86.2 by SHA across workflows and the commands dispatcher; locks reflect the new compiler.
    • Extension installs from github/gh-aw (moved from githubnext/gh-aw).

Written for commit 4b6f004. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Updates
    • Updated automated workflow components to newer versions for improved reliability and compatibility.
    • Enhanced workflow prompt handling, validation, and execution reporting.
    • Added clearer status reporting for processed, cancelled, deferred, skipped, and warning outcomes.
    • Improved agent and threat-detection execution with updated runtime preparation and logging.
    • Refined temporary file and container access handling across automated workflows.

Every warning on the detection ledger was one failure: the compiled
detection job hardcoded /usr/local/bin/copilot, which does not exist
inside its chroot sandbox, so the scan died at spawn in four
milliseconds with zero output and the empty log read as parse_error.
The lanes have never actually scanned anything since the side-scan
returned. Compiling with gh-aw v0.86.2 points the detection harness at
the runner-temp copilot the chroot can see; the model pins stay, the
external-detector path with its unpinned fetch does not compile in, and
the only moved action pin is gh-aw's own setup at its matching sha.
The version is a pinned prerelease because stable v0.85.4 is what emits
the dead path, and the extension now installs from github/gh-aw, where
the project moved.
Copilot AI lite review requested due to automatic review settings August 12, 2026 06:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The PR upgrades generated gh-aw workflows and action locks to v0.86.2. It updates prompt generation, Copilot execution, MCP gateway configuration, threat detection, validation schemas, runtime metadata, and safe-output job outputs.

Changes

gh-aw workflow upgrade

Layer / File(s) Summary
Toolchain and prompt generation
.github/aw/actions-lock.json, .github/workflows/agent-mention.lock.yml, .github/workflows/agent-review.lock.yml, .github/workflows/agent-triage.lock.yml, .github/workflows/agentic_commands.yml
The workflows use gh-aw v0.86.2, Copilot 1.0.79, and refreshed action and image pins. Prompt creation uses create_prompt.cjs, runner-temporary paths, validation, and artifact staging.
Safe-output validation and MCP gateway
.github/workflows/agent-mention.lock.yml, .github/workflows/agent-review.lock.yml, .github/workflows/agent-triage.lock.yml
Safe-output validation adds identifier, target, and temporary-ID fields. MCP gateway configuration adds mount roots, temporary mounts, and refreshed container images.
Agent execution and Copilot staging
.github/workflows/agent-mention.lock.yml, .github/workflows/agent-review.lock.yml, .github/workflows/agent-triage.lock.yml
Agent jobs install ripgrep, validate Copilot on PATH, copy it to a runner-local binary, and invoke it through the firewall with /tmp/gh-aw mounted.
Threat detection and safe-output reporting
.github/workflows/agent-mention.lock.yml, .github/workflows/agent-review.lock.yml, .github/workflows/agent-triage.lock.yml
Threat detection uses shared preparation, step-summary handling, and rendered logs. Safe-output jobs expose applied, cancelled, deferred, skipped, and warning counts. Failure issue expiration is set to zero hours.

Estimated code review effort: 4 (Complex) | ~45 minutes

Possibly related PRs

  • HardMax71/amiss#368: Both PRs modify the generated gh-aw workflow infrastructure and action lock files.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: making the Copilot executable reachable from the side-scan chroot.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-detection-sandbox

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/agentic_commands.yml:
- Line 56: Update the setup action reference in the workflow to use the locked
commit SHA 6aab9e5b5c91c615506061f09bedd81a23babe3c, retaining the v0.86.2
version comment.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7c204ba4-9fad-4db6-94bb-f6e4a3426f4f

📥 Commits

Reviewing files that changed from the base of the PR and between 49b1e36 and f1a4ead.

📒 Files selected for processing (5)
  • .github/aw/actions-lock.json
  • .github/workflows/agent-mention.lock.yml
  • .github/workflows/agent-review.lock.yml
  • .github/workflows/agent-triage.lock.yml
  • .github/workflows/agentic_commands.yml

Comment thread .github/workflows/agentic_commands.yml Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread .github/workflows/agentic_commands.yml Outdated
Both reviewers are right that the one credentialed job still reached its
setup action by mutable tag while every lock and the pin ledger hold the
resolved sha. The compiler's commands dispatcher ignores its own ledger
even under --action-mode action, an upstream gap, so the pin is applied
by hand and holds until the next manual recompile.
@HardMax71
HardMax71 merged commit 79448e7 into main Aug 12, 2026
30 checks passed
@HardMax71
HardMax71 deleted the fix-detection-sandbox branch August 12, 2026 06:48

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

The chroot copilot fix is real and consistent across all three lanes, but the claim that gh-aw setup was the only moved action pin is wrong: taiki-e/install-action also moved in every lock.

agent-mention.lock.yml#L470 — "only moved action pin" claim is inaccurate

The PR body says "the only moved action pin is gh-aw setup at its matching sha," but the install-action uses: line here also moved from cb33e69f (Release 2.85.8, 2026-08-04) to 18b1216 (Release 2.85.3, 2026-07-28) in all three lock files.

It reads as a consistency correction, not a deliberate downgrade: the base lock was internally inconsistent — its own manifest header and the source agent-mention.md#L26 already declared 18b1216 while the uses: line executed cb33e69f — and the recompile re-aligned the executed pin to the declared one. Same delta in agent-review.lock.yml and agent-triage.lock.yml.

Confidence: High that the pin moved and the claim is false; low that it was a deliberate downgrade.

Verified in the tree, not from the diff: the fix mechanics hold — copilot is copied from command -v copilot to ${RUNNER_TEMP}/gh-aw/bin/copilot, invoked quoted inside the chroot, and /tmp/gh-aw is mounted :rw, in both agent and detection paths of all three lock files, with no /usr/local/bin/copilot remaining anywhere. The dispatcher's setup pin is correctly SHA-locked (4b6f004), the deepseek model pins are unchanged, and the external-detector path is not compiled in.

Session details
  • run
  • Reviewed PR #387 head 4b6f004 against base 49b1e36: diff-verified the copilot-in-chroot fix, action pins (setup, install-action), dispatcher pin, model pins, and CI state.

name: activation
path: /tmp/gh-aw
- uses: taiki-e/install-action@cb33e69fad06166ca28a42b2575e4dadabf62ee8 # 18b1216eba7f8039b0f8d131d5473787f0edce68
- uses: taiki-e/install-action@18b1216eba7f8039b0f8d131d5473787f0edce68 # 18b1216eba7f8039b0f8d131d5473787f0edce68

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR body's claim that "the only moved action pin is gh-aw setup at its matching sha" is inaccurate: taiki-e/install-action's executed pin also moved in all three lock files.

The base lock ran cb33e69f (Release 2.85.8, 2026-08-04) and the head locks run 18b1216 (Release 2.85.3, 2026-07-28) — a step back one release. What makes it look like a correction rather than a chosen downgrade: the base lock was internally inconsistent (its own manifest header and the source agent-mention.md#L26 already declared 18b1216 while the uses: line executed cb33e69f), and the recompile re-aligned the executed pin to the declared one. Same delta in agent-review.lock.yml and agent-triage.lock.yml.

Confidence: High that the pin moved and the "only moved pin" claim is false; low that it was a deliberate downgrade — it re-aligns to the pin the source already declared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants