Repository navigation
feat: ship AGENTS.md and CLAUDE.md in scaffolded projects - #154
alekshaugom wants to merge 1 commit into
Conversation
They point agents to the harper-architecture skill before planning so agents build Harper-native instead of multi-service stacks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request adds AI agent instructions (AGENTS.md and CLAUDE.md) to several Harper application templates and updates the integration tests to assert their presence. Feedback on the pull request suggests adding 'early-hints' to the WITHOUT_AGENT_INSTRUCTIONS_TEMPLATES set in the integration tests if it is a legacy template that should be excluded from receiving these instructions.
dawsontoth
left a comment
There was a problem hiding this comment.
This shouldn't be the purview of this repo, copying stuff into the templates from the skills. If the skills repo isn't placing things in the right place, then let's update it to place things in the right place. Don't hard code things into the templates that the templates won't keep up to date, spreading logic across multiple repos, complicating updates.
Why
Skills load on demand, but the decision about which services to use happens before any skill loads.
AGENTS.mdis read at the start of every agent session, so it's where we can say "Harper is the whole backend" before the agent starts planning a stack.npm create harperalready installs the Harper skills into.agents/skills/. This file makes sure the agent reads the right one first.What this adds
Two files in
templates-shared/all/, applied to every template:AGENTS.mdcovers:.agents/skills/harper-architecture/SKILL.mdbefore planning, or runnpm run agent:skills:updateif it's missing.harper-best-practicesrule before implementing.redis,express,socket.io,@aws-sdk/client-s3; a second server; sessions in aMap; hand-rolled password hashing).CLAUDE.md: one line,@AGENTS.md, so Claude Code loads the same instructions.Coverage:
template-*dirs.templates-sharedfan-out, and their layout differs (app/, rootschema.graphql,@harperfast/nextjs). They need either a joined fan-out or their own variant. The test excludes them by name, so the gap can't go unnoticed._github, if preferred.Test: the existing per-template integration test, which runs the real CLI, now checks that
AGENTS.mdpoints toharper-architectureand thatCLAUDE.mdis@AGENTS.md. 41 test files, 366 tests pass.Feedback wanted
Please comment on the wording of
AGENTS.mdnow, even though it can't merge yet. It's the first thing every agent reads in a new Harper project.Related
feat: add harper-architecture skill(blocks this PR)feat: add replaces field and Instead-of line to rules🤖 Generated with Claude Code