feat: add security testing utilities for mTLS certificate verification#1
Open
Ethan-Arrowood wants to merge 1 commit intomainfrom
Open
feat: add security testing utilities for mTLS certificate verification#1Ethan-Arrowood wants to merge 1 commit intomainfrom
Ethan-Arrowood wants to merge 1 commit intomainfrom
Conversation
Extracts OCSP and CRL testing utilities from harper's integration test suite into a reusable module. Adds pure-Node.js certificate generation (via pkijs + webcrypto), an OCSP responder server, a CRL server, and high-level setup helpers for both protocols — with no openssl CLI dependency. Also fixes the build configuration by adding an explicit rootDir and skipLibCheck, updates @types/node for TypeScript 6 compatibility, and documents all new APIs in the README. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kriszyp
reviewed
Apr 28, 2026
Member
kriszyp
left a comment
There was a problem hiding this comment.
I'm curious about the motivation for this, and why this is deemed generic enough to exist in the integration framework instead of the project testing this? (The PR description doesn't really indicate)
Member
Author
|
I assume these utils would be relevant for other projects that may want to do similar security testing. Anything from harper-pro to plugins or applications. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
harper's integration test suite into this reusable modulepkijs+ Node.jswebcrypto, noopensslCLI), an OCSP responder server, a CRL HTTP server, and high-levelsetupOcspResponderWithCerts/setupCrlServerWithCertshelpersindex.ts) and documents them in the READMErootDirtotsconfig.build.json, addsskipLibCheckforpkijs/asn1jsTS6 compatibility, upgrades@types/nodeto22.15.21New exports
Test plan
@harperfast/integration-testingnpm run buildsucceeds cleanlynpm run checkpassesNext steps
After this PR is merged and released, the
extract-integration-testing-frameworkbranch inharperwill be updated to consume the released version and remove the now-redundantintegrationTests/utils/security/directory.🤖 Generated with Claude Code