Fix build typings and default API URL#2
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds a default API URL fallback to the SDK configuration, relaxes validation to require only an API key, and explicitly exports the public configuration type and functions. It also adds TypeScript node type definitions to development dependencies. ChangesSDK Configuration and API Surface
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
tsccan resolve the package'sprocessandfetchglobalsgetConfig()use the documentedhttps://api.hashlock.marketsdefault whenHASHLOCK_API_URLis not setHASHLOCK_API_KEYrequiredBefore this change,
npm run buildfails withTS2580forprocessandTS2304forfetch.Validation
npm install --no-package-locknpm run buildHASHLOCK_API_KEY=test node -e "const { getConfig } = require('./dist/index.js'); const cfg = getConfig(); console.log(JSON.stringify(cfg));"Summary by CodeRabbit
New Features
https://api.hashlock.marketswhen not providedChores