fix(mcp): sdk ^0.2.0 + drop cast bypasses + amount-unit cross-surface notes (audit SDK-pin, HL-03)#11
Conversation
…antics (audit SDK-pin + HL-03) - @hashlock-tech/sdk ^0.1.4 -> ^0.2.0: the old pin forced 'as unknown as SwapClient' and a Parameters<...> cast that suppressed ALL structural checking at the facade boundary (type-drift risk flagged by the audit). Both casts removed; swapClient is now a plain typed assignment. - list_my_trades status filter becomes the real TradeStatus enum (the free-string input was the reason for one cast and gave agents no guidance on valid states). - HL-03: amount descriptions now carry the cross-surface warning — this MCP surface is raw DECIMAL strings; the intents surface (intent-schema/ ai-sdk) is smallest-unit INTEGER strings. The two LLM-facing surfaces previously described the same logical field with opposite units and no cross-reference (1e18 mis-scale hazard for agents operating on both). tsc clean, 137/137 tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 50 minutes and 1 second. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Audit Wave-3 PR-10 (mcp part). sdk bumped to the published 0.2.0; both
as unknown asbypasses removed (one replaced by a typed TradeStatus enum input on list_my_trades); HL-03 cross-surface unit warnings added to the decimal amount descriptions, mirroring the integer-unit note now in intent-schema. tsc clean, 137/137.🤖 Generated with Claude Code