Repository navigation
Chore/http server - #666
Merged
Merged
Conversation
- Implement tests for manifest parsing, entry graph collection, and link header generation. - Validate document request detection and HTTP/2 push middleware functionality. - Ensure proper handling of asset files and dynamic imports in the manifest. - Introduce environment configuration tests for HTTP/2 push options. - Utilize temporary directories for testing manifest file reading and writing.
|
@devonahi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1 — No multi-resolution layout coverage; fixed header clipped on phones
The site had no cross-device layout testing, and the fixed nav's links/status pills ran 160 px past a 375 px viewport (invisible, unscrollable). Added tests/e2e/layout.spec.ts: 6 device profiles (iPhone SE, iPhone 14, Pixel 7, iPad, Laptop, 4K) × 3 routes, asserting no horizontal scrollWidth, no right-edge clipping, landmark geometry, plus committed screenshot baselines. Fixed with wrapping nav, .hp-app-nav* media-query rules in src/App.css, clamp() hero heading, and fluid sizing in src/pages/Help.tsx. Wired into playwright.config.js (per-device projects), package.json (test:layout), and a PR-only e2e-layout-matrix job in CI.
2 — Broken build/tests blocked any verification
Duplicate imports/PERSIST_KEY in src/stores/helpStore.ts and duplicate DAO_CONTRACT_ID in src/lib/contract.ts failed Vite transforms (dev server + /help dead); test/snapshots.test.jsx had a bad import, stale snapshots, and an uninitialized-i18n crash in LanguageSwitcher. All fixed; snapshots refreshed with a new App snapshot — vitest failures down 251 → 246, tsc unchanged (30 pre-existing), vite build passes, layout matrix 36/36.
Related Issue
Closes #544
Closes #545