fix(vpn): retain stopJob and reset isStopping synchronously - #44
Merged
Conversation
Plan 014. Previously stopVpn() used a local CoroutineScope whose Job was unreachable from the service fields; a low-memory process pause between state=DISCONNECTED and stopSelf() could GC the cleanup coroutine mid- teardown, leaving Go core / TUN fd / WakeLock / NetworkCallback live. isStopping also stayed true until onDestroy(), blocking a fresh connect() during that gap. Fix: retain stopJob on the service so onDestroy() can join it, reset isStopping in a finally block inside the launch lambda so it goes false when teardown actually finishes, and add a DISCONNECTING guard to VpnManager.connect() so the UI can't race the disconnect dispatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan 014. Previously stopVpn() used a local CoroutineScope whose Job was unreachable from the service fields; a low-memory process pause between state=DISCONNECTED and stopSelf() could GC the cleanup coroutine mid- teardown, leaving Go core / TUN fd / WakeLock / NetworkCallback live. isStopping also stayed true until onDestroy(), blocking a fresh connect() during that gap. Fix: retain stopJob on the service so onDestroy() can join it, reset isStopping in a finally block inside the launch lambda so it goes false when teardown actually finishes, and add a DISCONNECTING guard to VpnManager.connect() so the UI can't race the disconnect dispatch.