web: sharpen EN copy, real nav icon buttons, native locale rewrites - #5289
web: sharpen EN copy, real nav icon buttons, native locale rewrites#5289Hmbown wants to merge 1 commit into
Conversation
Three fixes on the newspaper-ocean site:
- Nav: baseline-align the Han secondary labels with the Latin primary
(inline-flex items-baseline + matching line-height), and give the
masthead real brand buttons — GitHub mark before the star count,
Discord logo icon-only — with a .site-discord-link rule matching
.site-github-link and a shared .brand-mark size.
- EN copy: hero/meta/footer sharpened around "Codewhale dives into the
deep so you don't have to"; every "local-first" claim dropped in
favor of "any model, on your machine". heroIntro keeps the {brand}
token the lede split and dictionary tests require.
- Locales: home/chrome rewritten natively in all nine non-English
packs (zh, ja, ko, vi, ru, uk, es, id, pt-BR) instead of machine
translation. zh hero uses the 一入码门深似海 allusion per community
feedback. Key parity, template tokens, and ru/uk script purity all
hold; check:locales and dictionaries.test.ts pass.
Verified: npm ci && prebuild && check:facts && check:docs &&
check:locales && vitest (250/250) && eslint && tsc --noEmit && build.
Agent-assisted (Kimi Code); copy reviewed against the en reference.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Claude finished @Hmbown's task in 3m 40s —— View job Review of PR #5289
This PR is entirely in Bug: duplicated "Codewhale" in the OG/social card
But two call sites still prepend
This renders as "Codewhale — Codewhale dives into the deep so you don't have to — any model, on your machine." — and the actual generated PNG (
Fix: either drop "Codewhale" back out of Minor / non-blocking
Verified good
I wasn't able to install dependencies in this environment (no |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9f8c4df98
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /** The one-line product identity, used as the default OG image alt text. */ | ||
| export const IDENTITY_PHRASE = | ||
| "Dive into the deep so you don't have to — any model, local-first."; | ||
| "Codewhale dives into the deep so you don't have to — any model, on your machine."; |
There was a problem hiding this comment.
Because both OG_IMAGE.alt here and app/opengraph-image.tsx prepend SITE_NAME, adding “Codewhale” to IDENTITY_PHRASE makes every social-card alternative read Codewhale — Codewhale dives into the deep…. Screen-reader users encounter this duplicated label on every localized page; either keep the identity phrase brand-free or stop prepending the site name.
Useful? React with 👍 / 👎.
1 participant
What
inline-flex items-baseline+ matchingleading-none) innav-links.tsx.aria-labelkept). New.site-discord-linkbordered-button rule matching.site-github-link, plus shared.brand-marksizing.home.ts+chrome.tsrewritten natively in all nine non-English packs — zh, ja, ko, vi, ru, uk, es, id, pt-BR — mirroring the en structure and direction. The zh hero uses 「一入码门深似海，Codewhale 替你潜。」 per WeChat community feedback about MT-stiff copy.Contract held
Same i18n keys everywhere;
{brand}/{tag}/{count}/{date}/{mode}/{label}/{handle}tokens preserved; ru/uk script purity; seals and product names untouched.Verification
npm ci && npm run prebuild && npm run check:facts && npm run check:docs && npm run check:locales && npm test(250/250)&& npx eslint . && npx tsc --noEmit && npm run build— all green in the worktree.Deploy stays manual via the
web.ymlworkflow after merge.No-Issue: website copy and nav polish from direct maintainer/community feedback (WeChat review of MT-stiff locale copy); no tracking issue.