Remove dotabs and divmag - #27
Merged
Merged
Conversation
Covers are this package's subject. Neither function belonged to it: dotabs is a generic reduction with no connection to covers, and divmag was the only application-level entry point, layering a roundoff estimate on top of symcover. The roundoff-estimation use case that motivated divmag survives as a worked example in the manual, which derives the estimate from symcover directly. Presenting it as documentation rather than API keeps the scale-invariance argument visible instead of burying it in a function whose name explained none of it. The example also states the transformation law correctly: the estimate is scale-invariant under A -> D*A*D, b -> D*b, not scale-covariant. Assisted-by: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
- Coverage 98.51% 98.51% -0.01%
==========================================
Files 12 12
Lines 2027 2016 -11
==========================================
- Hits 1997 1986 -11
Misses 30 30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers are this package's subject. Neither function belonged to it:
dotabs is a generic reduction with no connection to covers, and divmag
was the only application-level entry point, layering a roundoff estimate
on top of symcover.
The roundoff-estimation use case that motivated divmag survives as a
worked example in the manual, which derives the estimate from symcover
directly. Presenting it as documentation rather than API keeps the
scale-invariance argument visible instead of burying it in a function
whose name explained none of it.
The example also states the transformation law correctly: the estimate
is scale-invariant under A -> DAD, b -> D*b, not scale-covariant.
Assisted-by: Claude Opus 4.8 noreply@anthropic.com