Give new Ingest candidates a real fixed boundary - #144
Open
p-linnane wants to merge 1 commit into
Open
Conversation
`--no-history` gave every new matched candidate a `fixed` of the formula's current `pkg_version` for reviewers to tighten by hand, because walking homebrew-core history for every `:fixed` hit would exceed the job limit. `brew advisory-match --new-history` walks only for records whose ranges are not already on disk: existing records keep the boundaries review gave them, and new ones get the version that first shipped the fix. Older brew does not know the flag, so a runner without it fails the step rather than walking every record; `stable: false` puts brew main on the runner. Signed-off-by: Patrick Linnane <patrick@linnane.io>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Ingest to preserve existing advisory boundaries while using Homebrew history to determine fixed versions for new candidates.
Changes:
- Runs Homebrew main with
stable: false. - Replaces
--no-historywith--new-history. - Adds workflow configuration assertions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Summary |
|---|---|
spec/workflows_spec.rb |
Verifies the updated Homebrew channel and matcher flags. |
.github/workflows/ingest.yml |
Enables Homebrew main and new-history matching. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ingest now runs
brew advisory-match --new-history, which walks homebrew-core history only for records whose ranges are not already on disk, so existing records keep their reviewed boundaries and new candidates get the version that first shipped the fix rather than the currentpkg_version.Needs Homebrew/brew#23610 on brew main first:
stable: falseputs brew main on the runner, and an older brew fails the step on the unknown flag rather than walking history for every record.