Invalidate bottle cache for local patches - #23597
Merged
Merged
Conversation
- Include local patch paths when checking formula changes. - Prevent stale bottles when a patch changes without its formula. - Cover the cache decision with a regression test.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Homebrew鈥檚 test-bot bottle-cache invalidation logic so that a cached bottle is considered invalid not only when the formula file changes, but also when any local patch file referenced by the formula changes. This addresses stale-bottle reuse when only a local patch has been modified.
Changes:
- Extend
no_diff?to include local patch file paths (fromformula.patchlist) in thegit diffpathspec used to decide cache validity. - Add a regression spec ensuring
artifact_cache_valid?rejects a cached bottle when only a local patch file has changed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/test_bot/test_formulae.rb | Include local patch paths in the git diff check that underpins bottle-cache validity decisions. |
| Library/Homebrew/test/test_bot/test_formulae_spec.rb | Add regression coverage for invalidating the artifact cache when a local patch changes without the formula changing. |
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
ZhongRuoyu
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23588
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.6 Sol xhigh with local review and (unit) testing.