refactor(audio): sample rate handling and dynamic format detection - #39
Merged
Conversation
- Add pipeline sample rate setting in Settings (presets: 44.1k, 48k default, 88.2k, 96k, 176.4k, 192k + 1 Hz custom stepper). - Add sample rate configuration per virtual device in Virtual Devices UI and HAL driver. - Ensure bit-transparent signal path without resampling when device and pipeline rates match. - Add input normalizer and output rate adaptation to eliminate Issue #32 capture startup mismatch crashes. - Bump virtual driver version to 5.
…ional codec metadata
…ec-driven metadata
…le recording layout
…m implementations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Configurable pipeline and virtual device sample rates:
44.1k,48kdefault,88.2k,96k,176.4k,192k+ 1 Hz custom stepper).SplitAudioDriver.cpp, bumped driver version to 5).rubatoresampling when source and pipeline sample rates match.Flow UI sample rate badge and minimal resample indicator:
ArrowSwapicon with tooltip (Resampling: 48 kHz → 96 kHz) only when a node undergoes resampling.48 kHz · 2 ch · f32) added across input/output nodes (microphone,speaker,app_audio,system_audio,file_recording,net_receiver,net_sender)Net Sender sample rate selection & Net Receiver dynamic format detection:
b0 < 0x80).MultiResamplerOut.Why is this the right approach?
Checklist
bun run checkpassescargo check --manifest-path src-tauri/Cargo.tomlpassesbun run formatleaves the tree cleanchange adds no allocations, locks, or syscalls to cpal / SCK callbacks
or
DspWorker::runPlatform coverage
Related