Maint#88
Merged
Merged
Conversation
Reviewer's GuideMaintenance update that refreshes supported Python versions, tidies project metadata and optional dependencies, fixes a pytest marker typo, and updates documentation assets and CI workflows to match the new support matrix. Flow diagram for installation and static image export requirementflowchart TD
User["User"] --> Install["Run pip install mutation_motif"]
Install --> UseCLI["Use mm CLI to create Plotly figures"]
UseCLI --> NeedStatic["Need static image export"]
NeedStatic --> ChromeDep["Install Chrome for Plotly static image export"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In
pyproject.tomlthedependencieslist still containsscipytwice; consider removing the duplicate entry to avoid confusion. - You’ve set
requires-python = ">=3.11,<=3.14"while also adding a 3.14 classifier and CI job; if the intention is simply “3.11+ until the next incompatible release,” using<3.15instead of<=3.14may reduce the need for frequent metadata updates.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `pyproject.toml` the `dependencies` list still contains `scipy` twice; consider removing the duplicate entry to avoid confusion.
- You’ve set `requires-python = ">=3.11,<=3.14"` while also adding a 3.14 classifier and CI job; if the intention is simply “3.11+ until the next incompatible release,” using `<3.15` instead of `<=3.14` may reduce the need for frequent metadata updates.
## Individual Comments
### Comment 1
<location path=".github/workflows/testing_develop.yml" line_range="16-19" />
<code_context>
matrix:
os: [macos-latest, ubuntu-latest]
- python-version: ["3.10", "3.13"]
+ python-version: ["3.11", "3.14"]
steps:
</code_context>
<issue_to_address>
**suggestion (testing):** Consider including all supported Python versions in the develop test matrix.
The metadata and release workflow list support for 3.11–3.14, but this workflow only runs 3.11 and 3.14. Unless there’s a specific reason to omit 3.12 and 3.13, adding them to the matrix would better cover version-specific issues.
```suggestion
strategy:
matrix:
os: [macos-latest, ubuntu-latest]
python-version: ["3.11", "3.12", "3.13", "3.14"]
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update project metadata, supported Python versions, CI matrices, and documentation assets.
Bug Fixes:
Enhancements:
CI:
Documentation: