Repository navigation
refactor(dev): unify local development supervision - #67
Closed
Hweinstock wants to merge 4 commits into
Closed
Hweinstock wants to merge 4 commits into
Hweinstock wants to merge 4 commits into
Conversation
Hweinstock
force-pushed
the
fix/dev-supervisor-refactor
branch
from
October 7, 2026 14:40
80026c8 to
8d7e659
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Local development duplicates cancellation and runtime lifecycle handling between a selected headless agent and supervised agents. Use the shared cancellation helper and
DevSupervisoracross modes while preserving output, readiness, error, and cleanup behavior. Keep changes focused on unifying the execution paths. The refactor removes more lines than it adds. Existing test cases remain intact; only three expected error values change to match the supervisor'sErrorrepresentation.Solution, by commit:
Related Issue
Related to aws#1690 and aws#257: preserve cleanup and surfaced startup errors during refactoring.
Documentation PR
Not applicable; commands, flags, and configuration remain unchanged.
Type of Change
Testing
bun testbun run test:e2e, or explained why they are not applicablebun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed themVerification:
bun test: 3,977 passed, zero failures; no test cases added or removed.bun run auditpassed.node dist/index.js --helppassed.Example compiled CLI evidence:
The live AWS deployment E2E suite was not run: AWS requests and deployment paths are unchanged. Existing tests and real compiled CLI local invocations verify the affected behavior.
Spec
DevSupervisoracross local-development modes.refactor.Checklist
No new tests were added: the existing cases remain, with three error expectations adapted for the refactored representation.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.