Skip to content

High order artificial dissipation ported from InductionEq#39

Open
simonius wants to merge 5 commits into
IANW-Projects:masterfrom
simonius:resurrect_ad
Open

High order artificial dissipation ported from InductionEq#39
simonius wants to merge 5 commits into
IANW-Projects:masterfrom
simonius:resurrect_ad

Conversation

@simonius

Copy link
Copy Markdown
Contributor

I ported parts of the dissipation code from InductionEq to this repository. I also added the possibility to set different dissipation strengths for different conserved variables, which can be useful for Ideal MHD.

@ranocha ranocha requested review from Kostaszki and ranocha June 27, 2019 10:21

@ranocha ranocha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply, I haven't been online in github for a while. Can you request a review (button on the right hand side), @simonius, or do you not have appropriate authorisation?

Comment thread kernel/artificial_dissipation.cl Outdated

for (i = -STENCIL_WIDTH_HOD + 1; i < 1; i++) {
diff_HOD_x(ix, iy, iz, bound_x, i, u, HOD_X);
diff_HOD_y(ix, iy, iz, bound_x, i, u, HOD_Y);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be bound_y (and bound_z below)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was my fault. Thanks.

@ranocha

ranocha commented Jul 1, 2019

Copy link
Copy Markdown
Member

Your opinion, @Kostaszki ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants