Conversation
|
Hey @gameroman, thanks for the contribution. We'll try to look into the PR soon, but I'd like to ask two things in the meantime:
|
|
Hi @gameroman, thank you for the contribution. Additionally to the change requests:
|
|
Thank you for the review, I’ll fix everything when I get back👍 |
c0c56c1 to
a1e1ea2
Compare
d01de36 to
c1986f5
Compare
Signed-off-by: Roman <dev@rman.dev>
8b201bb to
4a27b92
Compare
Signed-off-by: Roman <dev@rman.dev>
diatrcz
left a comment
There was a problem hiding this comment.
The changes look good. However, the dependency is still listed in devDependencies. To complete the removal of the extend dependency, it should also be removed from there, even if this requires additional updates to the test codebase.
|
Weird, not sure why |
|
If I run it locally |
Would you be able to push that change to this branch please? I've ran Or show the diif that you are getting |
Signed-off-by: Roman <dev@rman.dev>
Checklist
npm testpasses (tip:npm run lint-fixcan correct most style issues)