fix: drop unused russh-keys dependency - #955
Merged
Merged
Conversation
spnl-run's gce feature depended on both russh 0.62 and the separate russh-keys 0.49 crate for SSH key handling, but crates/spnl-run/src/vllm/gce/ssh_tunnel.rs only ever used russh's own bundled russh::keys module (no code references the standalone russh_keys crate). The unused dependency pinned an old russh-cryptovec 0.48.0 alongside the already-current 0.62.0 copy pulled in by russh itself, which is the actual source of two open Dependabot alerts (GHSA advisories for unchecked CryptoVec allocation/growth) that no version bump could resolve since 0.49 was already the latest release in that dead line. Signed-off-by: Nick Mitchell <nickm@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spnl-run'sgcefeature depended on bothrussh0.62 and the separaterussh-keys0.49 crate for SSH key handling, butcrates/spnl-run/src/vllm/gce/ssh_tunnel.rsonly ever usesrussh's own bundledrussh::keysmodule — no code references the standalonerussh_keyscrate.The unused dependency pinned an old
russh-cryptovec 0.48.0alongside the already-current0.62.0copy pulled in byrusshitself. That's the actual source of therussh-cryptovecDependabot alerts (GHSA advisories for unchecked CryptoVec allocation/growth) that no version bump could resolve, since 0.49 was already the latest release on that now-dead line.Removing the dependency drops the vulnerable duplicate entirely instead of chasing a fixed version that doesn't exist.
Test plan
.github/scripts/verify-feature-consistency.shpassescargo clippy --tests -- -D warningspasses for spnl-run, spnl, and spnl-cli with their full CI feature setscargo fmt --checkpasses