Skip to content

Fix issue with cdf attributes in Lo l1a datasets #3209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmplummer merged 1 commit into from
May 18, 2026
+10 −2
Merged

Fix issue with cdf attributes in Lo l1a datasets #3209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions imap_processing/lo/l1a/lo_l1a.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,9 @@ def add_dataset_attrs(
data=azimuth_60.values.astype(str),
name="azimuth_60_label",
dims=["azimuth_60_label"],
attrs=attr_mgr.get_variable_attributes("azimuth_60_label"),
attrs=attr_mgr.get_variable_attributes(
"azimuth_60_label", check_schema=False
),
)
azimuth_6 = xr.DataArray(
data=np.arange(0, 60, dtype=np.uint8),
Expand All @@ -255,7 +257,9 @@ def add_dataset_attrs(
data=azimuth_6.values.astype(str),
name="azimuth_6_label",
dims=["azimuth_6_label"],
attrs=attr_mgr.get_variable_attributes("azimuth_6_label"),
attrs=attr_mgr.get_variable_attributes(
"azimuth_6_label", check_schema=False
),
)

esa_step = xr.DataArray(
Expand Down
4 changes: 4 additions & 0 deletions imap_processing/tests/lo/test_lo_l1a.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import pandas as pd

from imap_processing import imap_module_directory
from imap_processing.cdf.utils import write_cdf
from imap_processing.lo.l1a.lo_l1a import lo_l1a


Expand Down Expand Up @@ -44,6 +45,9 @@ def test_lo_l1a():
for dataset, logical_source in zip(
output_dataset, expected_logical_source, strict=False
):
# Try writing out the dataset to cdf in an attempt to catch any issues
# with attributes that cdflib doesn't like
_ = write_cdf(dataset)
assert logical_source == dataset.attrs["Logical_source"]
for var in dataset:
if var in no_depend_0_vars or var.endswith("label"):
Expand Down
Loading