3210 bug lo l1b processing jobs failing due to cdf attributes#3212
Merged
Conversation
lacoak21
approved these changes
May 18, 2026
Contributor
lacoak21
left a comment
lacoak21
left a comment
There was a problem hiding this comment.
LGTM! Just a couple of questions.
| @@ -218,6 +218,7 @@ gt_end_met: | |||
|
|
|||
| h_background_rates: | |||
Contributor
There was a problem hiding this comment.
Since these are non time varying variables should these be labeled as support_data instead of data?
Contributor
Author
There was a problem hiding this comment.
I think that these should be dependent on epoch. This code was written by Vineet. I wrote a new issue to capture this: #3213
|
|
||
| l1b_bgrates_ds = l1b_backgrounds_and_goodtimes_ds[background_rate_fields] | ||
| l1b_bgrates_ds["epoch"] = l1b_backgrounds_and_goodtimes_ds["epoch"] | ||
| l1b_bgrates_ds = l1b_backgrounds_and_goodtimes_ds[background_rate_fields] |
Contributor
There was a problem hiding this comment.
Why is this getting removed?
Contributor
There was a problem hiding this comment.
Oh wait i see now its a duplicate 👍
Contributor
Author
|
@vineetbansal, |
tmplummer
merged commit 37945af
into
IMAP-Science-Operations-Center:dev
14 checks passed
tmplummer
deleted the
3210-bug---lo-l1b-processing-jobs-failing-due-to-cdf-attributes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
There were some problems with Lo L1B product attributes that were causing failures when writing to CDF. This PR fixes those issues.
Note that the bgrates product may need additional work. Variables in the cdf don't depend on the epoch dimension as I believe that they should. In fact, I think that none of the variables in the dataset depend on epoch. It seems like it is just thrown in just to have an epoch variable.
Closes: #3210