Skip to content

lo l1b goodtimes and bgrates write out bad cdfs #3218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmplummer merged 1 commit into from
May 18, 2026
+14 −14
Merged

lo l1b goodtimes and bgrates write out bad cdfs #3218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions imap_processing/lo/l1b/lo_l1b.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2654,26 +2654,23 @@ def l1b_bgrates_and_goodtimes( # noqa: PLR0912

epoch_values = met_to_ttj2000ns(np.array([r[0] for r in goodtime_rows]))

l1b_combined_ds.assign_coords(
epoch=xr.DataArray(
data=epoch_values,
name="epoch",
dims=["epoch"],
attrs=attr_mgr_l1b.get_variable_attributes("epoch", check_schema=False),
)
l1b_combined_ds["epoch"] = xr.DataArray(
data=epoch_values,
name="epoch",
dims=["epoch"],
attrs=attr_mgr_l1b.get_variable_attributes("epoch", check_schema=False),
)

# esa_step is a coordinate in this dataset, so pop the DEPEND_0 attribute
esa_step_attrs = attr_mgr_l1b.get_variable_attributes("esa_step")
esa_step_attrs.pop("DEPEND_0")
l1b_combined_ds.assign_coords(
esa_step=xr.DataArray(
data=np.arange(c.N_ESA_LEVELS + 1),
name="esa_step",
dims=["esa_step"],
attrs=esa_step_attrs,
)
l1b_combined_ds["esa_step"] = xr.DataArray(
data=np.arange(c.N_ESA_LEVELS, dtype=np.uint8) + 1,
name="esa_step",
dims=["esa_step"],
attrs=esa_step_attrs,
)
l1b_combined_ds = l1b_combined_ds.set_coords(["epoch", "esa_step"])

l1b_combined_ds["pivot"] = xr.DataArray(
data=np.float32(pivot),
Expand Down
3 changes: 3 additions & 0 deletions imap_processing/tests/lo/test_lo_l1b.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2208,6 +2208,8 @@ def test_l1b_bgrates_and_goodtimes_basic(anc_dependencies, attr_mgr_l1b):

# Check that bgrates dataset is cdf-able by writing to file
_ = write_cdf(l1b_bgrates_ds)
assert "epoch" in l1b_bgrates_ds.coords
assert "esa_step" in l1b_bgrates_ds.coords
Comment thread
tmplummer marked this conversation as resolved.

# Check bgrates dataset structure (BACKGROUND_RATE_FIELDS)
assert "h_background_rates" in l1b_bgrates_ds.data_vars
Expand All @@ -2221,6 +2223,7 @@ def test_l1b_bgrates_and_goodtimes_basic(anc_dependencies, attr_mgr_l1b):

# Check that goodtimes dataset is cdf-able by writing to file
_ = write_cdf(l1b_goodtimes_ds)
assert "epoch" in l1b_goodtimes_ds.coords

# Check goodtimes dataset structure (GOODTIMES_FIELDS)
assert "gt_start_met" in l1b_goodtimes_ds.data_vars
Expand Down
Loading