Skip to content

Fix infeasible torch validation splits#892

Closed
FlorianPfaff wants to merge 2 commits into
mainfrom
codex-20260628-validation
Closed

Fix infeasible torch validation splits#892
FlorianPfaff wants to merge 2 commits into
mainfrom
codex-20260628-validation

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Member

Summary

  • Extend the existing torch fit guard to cover additional torch-backed adaptation decoders when a requested stratified validation split is too small.
  • Restore the configured validation_fraction after the fallback fit path.
  • Add regression coverage for a 16-class, two-rows-per-class case with validation_fraction=0.1.

Tests

  • Not run locally: this environment cannot clone GitHub or install the repository dependency set. Added focused pytest regression coverage in tests/test_torch_weight_validation.py.

@github-actions

Copy link
Copy Markdown

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 22 0 0 1.17s
✅ COPYPASTE jscpd yes no no 21.28s
✅ MARKDOWN markdownlint 101 0 0 0 2.52s
✅ PYTHON ruff 796 0 0 0 0.61s
✅ REPOSITORY git_diff yes no no 0.13s
✅ YAML prettier 62 0 0 0 2.31s
✅ YAML v8r 62 0 0 9.95s
✅ YAML yamllint 62 0 0 1.62s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@github-actions

Copy link
Copy Markdown

Test Results

     4 files  ± 0       4 suites  ±0   4m 18s ⏱️ +27s
 3 054 tests + 3   3 018 ✅ +1   36 💤 +2  0 ❌ ±0 
12 216 runs  +12  12 072 ✅ +4  144 💤 +8  0 ❌ ±0 

Results for commit 4833597. ± Comparison against base commit f2f8d87.

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) June 28, 2026 21:43

Copy link
Copy Markdown
Member Author

Applied the relevant fix and regression coverage directly to main in follow-up commits (5d8b442, 3a33044), so closing this conflicted PR as superseded.

auto-merge was automatically disabled June 29, 2026 08:56

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant