Open World Patient Ranking Pipeline#286
Open
eveenhuis wants to merge 14 commits into
Open
Conversation
eveenhuis
marked this pull request as ready for review
July 23, 2026 21:19
dmjoy
approved these changes
Jul 24, 2026
dmjoy
left a comment
Contributor
There was a problem hiding this comment.
Mostly minor comments and overall LGTM. Perhaps most pressing would be to add a bit more to the Changelog, but the other things can be deferred to another PR (or included in a subsequent PR for OW).
Comment on lines
+104
to
+105
| self.followup_character_prompt = FollowupClarifyCharacterPrompt() | ||
| self.followup_tag_prompt = FollowupClarifyTagPrompt() |
Contributor
There was a problem hiding this comment.
These should probably be parameterized (i.e. added to the __init__ args)
Comment on lines
+2
to
+10
| defaults: | ||
| - /adm_component/misc@adm.step_definitions.action_parameter_completion: ow_action_parameter_completion | ||
| - /adm_component/misc@adm.step_definitions.tagging_adjustment: ow_tagging_adjustment | ||
| - override /adm: phase2_pipeline_direct_regression | ||
| - override /interface: ta3 | ||
| - override /adm_component/misc@adm.step_definitions.format_choices: ow_format_choices | ||
| - override /adm_component/alignment@adm.step_definitions.scalar_alignment: tournament_random_effects_tuple | ||
| - override /adm_component/misc@adm.step_definitions.ensure_chosen_action: ow_choice_to_action | ||
| - override /driver: itm_phase2_ow |
Contributor
There was a problem hiding this comment.
Wondering if it makes more sense to have new adm configs (I guess we would just need one for comp reg and one for direct reg) to base these experiment files off of.
Contributor
There was a problem hiding this comment.
I suspect there's a few more things we'd want to add to the changelog (new components etc.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased version of !283, includes changes from !273
See the description from those below: