Skip to content

[PW_SID:1128473] Fix two station roaming crashes #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IWDTestBot wants to merge 3 commits into
base: workflow
Choose a base branch
from
Open

[PW_SID:1128473] Fix two station roaming crashes #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb7901c
station: fix use-after-free in preauthenticate_cb
soooch Jul 16, 2026
cbe943f
netdev: reject reassociation while connect pending
soooch Jul 16, 2026
0f60405
station: fix NULL deref in ap_directed_roam
soooch Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/netdev.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4394,6 +4394,9 @@ int netdev_reassociate(struct netdev *netdev, const struct scan_bss *target_bss,
struct handshake_state *old_hs;
struct eapol_sm *old_sm;

if (netdev->connect_cmd_id || netdev->work.id)
return -EBUSY;

old_sm = netdev->sm;
old_hs = netdev->handshake;

Expand Down
7 changes: 5 additions & 2 deletions src/station.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2598,6 +2598,7 @@ static void station_preauthenticate_cb(struct netdev *netdev,
if (station_transition_reassociate(station, bss, new_hs) < 0) {
handshake_state_unref(new_hs);
station_roam_failed(station);
return;
}

handshake_state_unref(station->hs);
Expand Down Expand Up @@ -3272,8 +3273,7 @@ static void station_ap_directed_roam(struct station *station,
uint16_t dtimer;
uint8_t valid_interval;
bool can_roam = !station_cannot_roam(station);
bool ignore_candidates =
station->connected_bss->vendor_quirks.ignore_bss_tm_candidates;
bool ignore_candidates;

l_debug("ifindex: %u", netdev_get_ifindex(station->netdev));

Expand All @@ -3282,6 +3282,9 @@ static void station_ap_directed_roam(struct station *station,
return;
}

ignore_candidates =
station->connected_bss->vendor_quirks.ignore_bss_tm_candidates;

/*
* Sanitize the frame to check that it is from our current AP.
*
Expand Down
Loading