Skip to content

[PW_SID:1144590] Fix two crashes in the agent request path #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IWDTestBot wants to merge 2 commits into
base: workflow
Choose a base branch
from
Open

[PW_SID:1144590] Fix two crashes in the agent request path #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f84b4c
client: fix double free in agent prompts
imyp Aug 12, 2026
5954902
agent: clear pending_id on request timeout
imyp Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions client/display.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,6 +860,7 @@ void display_agent_prompt_release(const char *label)
if (!command_is_interactive_mode()) {
rl_callback_handler_remove();
l_io_destroy(io);
io = NULL;

return;
}
Expand Down Expand Up @@ -975,6 +976,7 @@ void display_exit(void)
rl_callback_handler_remove();

l_io_destroy(io);
io = NULL;

l_signal_remove(window_change_signal);

Expand Down
3 changes: 3 additions & 0 deletions src/agent.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ static void agent_finalize_pending(struct agent *agent,
}

pending = l_queue_pop_head(agent->requests);
if (!pending)
return;

switch (pending->type) {
case AGENT_REQUEST_TYPE_PASSPHRASE:
Expand Down Expand Up @@ -230,6 +232,7 @@ static void request_timeout(struct l_timeout *timeout, void *user_data)
struct agent *agent = user_data;

l_dbus_cancel(dbus_get_bus(), agent->pending_id);
agent->pending_id = 0;

send_cancel_request(agent, -ETIMEDOUT);

Expand Down
Loading