Skip to content

[PW_SID:1146634] wiphy: do not select FT AKMs if we are going to reject them later - #513

Open
IWDTestBot wants to merge 1 commit into
workflowfrom
1146634
Open

[PW_SID:1146634] wiphy: do not select FT AKMs if we are going to reject them later#513
IWDTestBot wants to merge 1 commit into
workflowfrom
1146634

Conversation

@IWDTestBot

Copy link
Copy Markdown
Owner

The condition for choosing a FT AKM for SAE does not match the condition
used further down the line to validate the permissibility of an FT AKM.

Make a minimal change to bring the two in line, just to prevent choosing
a FT AKM that we are going to reject anyway.

Tested on a BCM43455 (brcmfmac) device, firmware 7.45.265 (28bca26 CY),
where this change [among others] allows to associate with a network that
advertises WPA3-Personal+FT (w/o FT actually being used). Without this
change, the FT AKM is selected, subsequently triggering an assertion
and failing the association.

See: f5c5efa ("wiphy: allow FT AKM to be used if Auth/Assoc is not supported")
Signed-off-by: Ivan Shapovalov intelfx@intelfx.name

Note that the resulting condition (which I wrote to mirror condition in
netdev_handshake_state_setup_connection_type()) differs from the similar
condition for WPA2-FT just below, which also checks for 4-way handshake
offload in the !softmac arm:

WPA3-FT: (IE_AKM_IS_FT() && (softmac || roam_offload))
WPA2-FT: (IE_AKM_IS_FT() && (softmac || (psk_offload && roam_offload))

I do not have enough knowledge to tell if this is an omission or a
deliberate asymmetry between WPA2 and WPA3 implementations.

src/netdev.c | 7 +++++++
src/wiphy.c | 20 ++++++++++++++++----
2 files changed, 23 insertions(+), 4 deletions(-)


base-commit: d003d0e
change-id: 20260816-brcmfmac-ft-12fe2dfeb3ef

Best regards,

Ivan Shapovalov intelfx@intelfx.name

The condition for choosing a FT AKM for SAE does not match the condition
used further down the line to validate the permissibility of an FT AKM.

Make a minimal change to bring the two in line, just to prevent choosing
a FT AKM that we are going to reject anyway.

Tested on a BCM43455 (brcmfmac) device, firmware 7.45.265 (28bca26 CY),
where this change [among others] allows to associate with a network that
advertises WPA3-Personal+FT (w/o FT actually being used). Without this
change, the FT AKM is selected, subsequently triggering an assertion
and failing the association.

See: f5c5efa ("wiphy: allow FT AKM to be used if Auth/Assoc is not supported")
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
@IWDTestBot

Copy link
Copy Markdown
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 3.56 seconds
Result: PASS

Prep - Setup ELL
Test ID: setupell
Desc: Clone, build, and install ELL
Duration: 27.48 seconds
Result: PASS

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 59.28 seconds
Result: PASS

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 11.18 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 1.78 seconds
Result: PASS

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 73.52 seconds
Result: PASS

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 0.43 seconds
Result: PASS

@IWDTestBot

Copy link
Copy Markdown
Owner Author

Fetch PR
Test ID: fetch
Desc: Fetch the PR commits for this CI run
Duration: 2.70 seconds
Result: PASS

GitLint
Test ID: gitlint
Desc: Run gitlint with rule in .gitlint
Duration: 0.77 seconds
Result: FAIL

Output:

wiphy: do not select FT AKMs if we are going to reject them later
39: B2 Line has trailing whitespace: "--  "

Prep - Setup ELL
Test ID: setupell
Desc: Clone, build, and install ELL
Duration: 30.98 seconds
Result: PASS

Make Distcheck
Test ID: makedistcheck
Desc: Run distcheck to check the distribution
Duration: 42.29 seconds
Result: PASS

Build - Configure
Test ID: build
Desc: Configure the BlueZ source tree
Duration: 23.33 seconds
Result: PASS

Make Check
Test ID: makecheck
Desc: Run 'make check'
Duration: 4.80 seconds
Result: PASS

Make Check w/Valgrind
Test ID: makecheckvalgrind
Desc: Run 'make check' with Valgrind
Duration: 110.39 seconds
Result: PASS

Incremental Build with patches
Test ID: incremental_build
Desc: Incremental build per patch in the series
Duration: 0.54 seconds
Result: PASS

Autotest Runner
Test ID: testrunner
Desc: Runs IWD's autotest framework
Duration: 1850.82 seconds
Result: PASS

Clang Build
Test ID: clang
Desc: Build IWD using clang compiler
Duration: 112.32 seconds
Result: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants