feat(theme): background pattern library + wallpaper storage - #3
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the site-wide personalization batch — the pattern half of the theme system. The theme engine (separate PR on batch/theme-engine) discovers these via import.meta.glob.
What
packages/web/src/lib/theme/patterns/: doodles, constellation (Stars), waves, crosshatch (Linen), dotgrid, circuit, petals, diamonds. Each default-exports{ key, label, tile, generate(colorHex, opacity) }returning an encodedurl("data:image/svg+xml,...")CSS layer.packages/web/src/lib/theme/wallpaper.ts:readWallpaper/storeWallpaper/clearWallpaperon the localStorage keybg-theme-wallpaper-v1(engine contract). Rejects non-image data URLs and payloads over 2MiB after base64 encoding; quota errors return{ ok: false }instead of throwing.Hardening (from code review)
generate()clamps opacity to [0,1] and validates colorHex (grey fallback) — encodeURIComponent leaves quotes unescaped, so an arbitrary string could otherwise break out of the SVG attributes.readWallpaperre-applies thedata:image/check so a value planted under the key never reaches the engine.Verification
pnpm -r typecheck,pnpm lint,pnpm testall green (core 1239, server 473, web 1109).Note for the engine worker: the
import.meta.globoverpatterns/must exclude*.test.ts(documented in patterns.test.ts).🤖 Generated with Claude Code
https://claude.ai/code/session_011r16ejkf3HB6tyZfTeA3Eb