Fix broken runtime config sync - #10126
Merged
Merged
Conversation
icinga-probot
Bot
added
area/api
Al2Klimov
force-pushed
the
broken-runtime-config-sync-2.13
branch
from
August 21, 2024 14:14
346d0c1 to
cf4a931
Compare
Al2Klimov
changed the title
Al2Klimov
force-pushed
the
broken-runtime-config-sync-2.13
branch
from
September 17, 2024 14:45
cf4a931 to
dd5aa2c
Compare
Member
I wouldn't backport this PR to 2.13.x, I mean it's not already backported for a reason, and yet backporting it purely due to a cherry pick dependency doesn't make sense to me. You can easily fix the cherry pick conflicts without having to backport this PR. |
Member
Author
|
The part I've backported just defines a few classes, this won't break anything 100%. |
Member
But why do you need to backport the classes in the first place then? As I said, the cherry pick conflict is pretty trivial and there is no need to backport something that isn't going to be used anyway. |
Al2Klimov
force-pushed
the
broken-runtime-config-sync-2.13
branch
from
September 20, 2024 09:08
dd5aa2c to
80e8c16
Compare
yhabteab
approved these changes
Sep 20, 2024
yhabteab
left a comment
yhabteab
left a comment
Member
There was a problem hiding this comment.
Please adjust the PR description accordingly!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.