Skip to content

Introduce Checkable#scheduler_shuffle_cap - #7718

Open
Al2Klimov wants to merge 1 commit into
masterfrom
feature/scheduler-shuffle
Open

Introduce Checkable#scheduler_shuffle_cap#7718
Al2Klimov wants to merge 1 commit into
masterfrom
feature/scheduler-shuffle

Conversation

@Al2Klimov

@Al2Klimov Al2Klimov commented Dec 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

fixes #7622

@Al2Klimov Al2Klimov added this to the 2.12.0 milestone Dec 17, 2019
@Al2Klimov

Al2Klimov commented Dec 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

TODO

  • get green light
  • passive checks?
  • docs

@Al2Klimov

Al2Klimov commented Dec 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

This one introduces a new config precentage attribute for additionally shaking the next check around based on the check interval. Default: 0% – no breaking change.

0% (checks/s)

before

20%

after

@Al2Klimov
Al2Klimov marked this pull request as ready for review December 17, 2019 11:22
@Al2Klimov
Al2Klimov requested a review from dnsmichi December 17, 2019 11:22
@Al2Klimov

Al2Klimov commented Dec 17, 2019

Copy link
Copy Markdown
Member Author

This should be a good Xmas gift of the one of our customers with high check latencies.

@Al2Klimov
Al2Klimov requested a review from lippserd December 17, 2019 11:56
@dnsmichi

dnsmichi commented Dec 18, 2019

Copy link
Copy Markdown
Contributor

I've talked with @lippserd about that, we will re-iterate on that for a later version. 2.12 only waits for the JSON-RPC bug and is feature frozen.

@dnsmichi dnsmichi modified the milestones: 2.12.0, 2.13.0 Dec 18, 2019
@Al2Klimov

Al2Klimov commented Mar 12, 2020

Copy link
Copy Markdown
Member Author

@lippserd Shall we default this one to 20, not to 0 so by default we de-spike the checks, but the user can disable that if they've got a grapher w/ slots?

@Al2Klimov Al2Klimov added the needs feedback We'll only proceed once we hear from you again label Mar 12, 2020
@Al2Klimov
Al2Klimov removed the request for review from dnsmichi March 30, 2020 09:53
@Al2Klimov

Al2Klimov commented Mar 30, 2020

Copy link
Copy Markdown
Member Author

Btw. this would automatically run much less e.g. ping checks to the same address concurrently.

@Al2Klimov

Al2Klimov commented Aug 27, 2020

Copy link
Copy Markdown
Member Author

bump

@lippserd

lippserd commented Sep 15, 2020

Copy link
Copy Markdown
Member

We should stick with the 0% default. Documentation is missing.

@Al2Klimov
Al2Klimov removed the request for review from lippserd September 15, 2020 09:26
@Al2Klimov Al2Klimov removed the needs feedback We'll only proceed once we hear from you again label Sep 15, 2020
@Al2Klimov
Al2Klimov marked this pull request as draft September 15, 2020 09:27
@Al2Klimov Al2Klimov self-assigned this Sep 15, 2020
@Al2Klimov
Al2Klimov force-pushed the feature/scheduler-shuffle branch 2 times, most recently from 54a3f4e to fa3afdd Compare September 15, 2020 09:40
@Al2Klimov Al2Klimov assigned N-o-X and unassigned Al2Klimov Sep 15, 2020
@Al2Klimov Al2Klimov added the needs feedback We'll only proceed once we hear from you again label Sep 15, 2020
@Al2Klimov Al2Klimov added the stalled Blocked or not relevant yet label Dec 14, 2020
@julianbrost julianbrost modified the milestones: 2.13.0, 2.14.0 May 31, 2021
@Al2Klimov

Al2Klimov commented Aug 4, 2021

Copy link
Copy Markdown
Member Author

@cla-bot check

@cla-bot cla-bot Bot added the cla/signed label Aug 4, 2021
@Al2Klimov

Al2Klimov commented Aug 10, 2021

Copy link
Copy Markdown
Member Author

@lippserd I.e. you plan to include this?

@N-o-X N-o-X removed their assignment Dec 6, 2021
@julianbrost julianbrost removed this from the 2.14.0 milestone Jan 12, 2023
@Al2Klimov
Al2Klimov force-pushed the feature/scheduler-shuffle branch from fa3afdd to 2e78189 Compare May 17, 2023 15:53
@Al2Klimov
Al2Klimov force-pushed the feature/scheduler-shuffle branch from 2e78189 to 81143d6 Compare June 1, 2023 16:30
@Al2Klimov
Al2Klimov marked this pull request as ready for review June 1, 2023 16:30
@Al2Klimov Al2Klimov added this to the 2.15.0 milestone Jan 21, 2025
@Al2Klimov
Al2Klimov force-pushed the feature/scheduler-shuffle branch from 81143d6 to 8c9478e Compare February 3, 2025 17:00
@julianbrost julianbrost removed this from the 2.15.0 milestone Apr 8, 2025
@Al2Klimov
Al2Klimov force-pushed the feature/scheduler-shuffle branch from 8c9478e to bbc25b3 Compare April 30, 2025 15:33
@Al2Klimov
Al2Klimov force-pushed the feature/scheduler-shuffle branch from bbc25b3 to a076e74 Compare May 28, 2025 15:35
@Al2Klimov
Al2Klimov force-pushed the feature/scheduler-shuffle branch from a076e74 to 0584483 Compare July 8, 2025 15:55
@Al2Klimov
Al2Klimov force-pushed the feature/scheduler-shuffle branch from 0584483 to f5ea785 Compare August 28, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla/signed needs feedback We'll only proceed once we hear from you again stalled Blocked or not relevant yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Evaluate a better algorithm for the check scheduler logic

5 participants

@Al2Klimov @dnsmichi @lippserd @julianbrost @N-o-X