Skip to content

Application::m_LastReloadFailed: if double isn't always lock free, use uint32_t - #9827

Merged
Al2Klimov merged 1 commit into
masterfrom
application-m_lastreloadfailed-uint32_t
Jul 10, 2023
Merged

Application::m_LastReloadFailed: if double isn't always lock free, use uint32_t#9827
Al2Klimov merged 1 commit into
masterfrom
application-m_lastreloadfailed-uint32_t

Conversation

@Al2Klimov

@Al2Klimov Al2Klimov commented Jul 10, 2023

Copy link
Copy Markdown
Member

which will overflow in 2106, not 2038.
This fixes a compile failure on 32-bit Raspbian.

TODO

  • OK from reviewer
  • OK from GHA
  • OK from GitLab
  • change log entry

…e uint32_t

which will overflow in 2106, not 2038.
This fixes a compile failure on 32-bit Raspbian.
@Al2Klimov Al2Klimov added the core/build-fix Follow-up fix, not released yet label Jul 10, 2023
@Al2Klimov
Al2Klimov requested a review from julianbrost July 10, 2023 08:59
@cla-bot cla-bot Bot added the cla/signed label Jul 10, 2023
@Al2Klimov

Copy link
Copy Markdown
Member Author

@Al2Klimov Al2Klimov added this to the 2.14.0 milestone Jul 10, 2023

@julianbrost julianbrost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good.

change log entry

Here or in #9760?

@Al2Klimov
Al2Klimov enabled auto-merge July 10, 2023 10:57
@Al2Klimov
Al2Klimov merged commit 1df14d6 into master Jul 10, 2023
@icinga-probot
icinga-probot Bot deleted the application-m_lastreloadfailed-uint32_t branch July 10, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed core/build-fix Follow-up fix, not released yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants