Implment api to get albums from an artist#47
Open
imgen wants to merge 6 commits into
Open
Conversation
IcySnex
reviewed
Jun 12, 2026
| /// <returns>A list of the <see cref="ArtistAlbum"/> containing the information</returns> | ||
| /// <exception cref="HttpRequestException">Occurs when the HTTP request fails.</exception> | ||
| /// <exception cref="OperationCanceledException">Occurs when this task was canceled.</exception> | ||
| public async Task<ArtistAlbums> GetAllByArtistAsync( |
Owner
There was a problem hiding this comment.
Getting all albums by an artist is a feature of the artist-broswe page. I think we should rather move this to ArtistService.cs
| namespace YouTubeMusicAPI.Services.Albums; | ||
|
|
||
| /// <summary> | ||
| /// |
Owner
There was a problem hiding this comment.
Suggested change
| /// | |
| /// Represents a list of all YouTube Music albums of an artist |
| { | ||
| Ensure.NotNullOrEmpty(browseId, nameof(browseId)); | ||
|
|
||
| const string paramsValue = "ggMIegYIARoCAQI%3D"; |
Owner
There was a problem hiding this comment.
Is this paramsValue required? Seems randomly generated. Did you try to send the request without it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The corresponding task is Get all albums from an artist