Fix XY coupling sign/scale in build_bfg - #1
Merged
Conversation
Sp/Sm in nicole's U1 convention are spherical components with a 1/2 normalization factor, so the leading/terminal tensor product picks up an extra 1/2. Use -2*Jperp instead of -Jperp to correctly implement -Jperp * (S+_i S-_j + S-_i S+_j).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_bfg'sXYinteraction term usedintr.cpl = -Jperp, but nicole's U1Sp/Smoperators are spherical components (Sp = -S+/sqrt(2),Sm = S-/sqrt(2)), so the leading/terminal tensor product carries an extra1/2factor.-2.0 * Jperp(with an explanatory comment) so the model correctly implements-Jperp * (S+_i S-_j + S-_i S+_j).sha256digest formodel_bfginregistry.yamlto match.Test plan
python tools/verify_registry.pyreportsOKformodels/model_bfg.pyverify-registryCI check passes on this PR