Skip to content

refactor(*): bundle styles with components - #15125

Open
simeonoff wants to merge 415 commits into
masterfrom
simeonoff/scoped-styles
Open

refactor(*): bundle styles with components#15125
simeonoff wants to merge 415 commits into
masterfrom
simeonoff/scoped-styles

Conversation

@simeonoff

@simeonoff simeonoff commented Dec 2, 2024

Copy link
Copy Markdown
Collaborator

Closes #13770, #16794

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@simeonoff simeonoff added ❌ status: awaiting-test PRs awaiting manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Feb 18, 2025
simeonoff and others added 20 commits February 21, 2026 12:58
# Conflicts:
#	package-lock.json
#	src/app/app.component.html
…put-group

- Fix styling issues
- Wrapper components (combo, select, date-picker, time-picker,date-range-picker) now forward their @ContentChildren hints to the inner igx-input-group, matching the existing pattern for prefixes and suffixes. This ensures @if (hasHints) works correctly when hints are dynamically added or removed through wrapper components.
…ton themes

- Add `--size` variable for `igx-icon` within buttons for consistent sizing.
- Apply `aspect-ratio` to FAB buttons for proper circular appearance.
- fix issues in Material, Indigo, Fluent, and Bootstrap themes for the date-range-picker.
- Refactored date-range-picker grid layout for better alignment and flexibility.
- Adjusted input group size variables and spacings for consistency across themes.
- Change `box-shadow` to `inset` for consistency in Material, Fluent, Bootstrap, and Indigo themes.
- Refactor date-range-picker sample to use dynamic labels and hints.
- Update theme variables to use Material palette/schema.
- Adjust grid-row layout for better alignment in date-range-picker.
desig9stein and others added 6 commits March 18, 2026 10:03
…omponent in favor of global one,

 update layout styles for samples app.
 use igx-navbar.
…yles

# Conflicts:
#	projects/igniteui-angular/core/src/core/styles/components/grid/_grid-theme.scss
- Updated Divider, DropDown, and Properties Panel samples to use new layout configurations.
- Improved color sample functionality with hex copying and dynamic palette updates.
- Refactored Color sample to simplify structure and enhance usability.
- Applied scoped styles and updated component themes for consistency.
- Resolved layout inconsistencies in Divider and DropDown demos.
Copilot AI review requested due to automatic review settings July 28, 2026 07:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings July 28, 2026 09:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings July 28, 2026 10:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings July 28, 2026 11:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 3, 2026 08:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 3, 2026 12:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

The '.igx-drop-down' panel had no intrinsic width, so once it lost the
container width constraint it previously inherited from the global
theme, it stretched to fill its nearest block ancestor.

'position: absolute' also restores shrink-to-fit sizing but pulls the
panel out of normal flow, which stops it from contributing its height
to '.igx-overlay__content' (whose height is otherwise never set
explicitly). That broke vertical-flip/positioning math in overlay
positioning strategies (regressed IgxAutocomplete top-direction
positioning and IgxSimpleCombo's open-upward-when-no-room behavior).

'width: max-content' gives the same shrink-to-fit sizing while keeping
the panel in normal flow, so it still drives the overlay content
wrapper's auto height correctly.
Copilot AI review requested due to automatic review settings August 3, 2026 13:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 3, 2026 14:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings August 4, 2026 07:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Themes: Scope component styles to component

6 participants