fix(dropdown): target overloads - toggle interop method, return types - #288
Merged
Conversation
damyanpetev
marked this pull request as ready for review
August 3, 2026 12:30
damyanpetev
enabled auto-merge (squash)
August 3, 2026 12:32
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the IgbDropdown “target” overloads so they call the correct JS method (toggle instead of show) and align their return semantics with the rest of the show/hide/toggle API, while extending the interop contract test harness to validate element-handle marshalling and adding unit coverage for the corrected overloads.
Changes:
- Fix
IgbDropdown.Toggle(Object)to invoke"toggle"and update target overloads to returnbool/Task<bool>with proper return decoding. - Extend the interop test harness/contract model to capture and assert
ElementReferencehandle payloads and render-sourced expected values. - Add
DropdownTestscoverage for show/toggle target overloads for both component andElementReferenceanchors.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/IgniteUI.Blazor.Tests/Interop/RendererMessageInteropHarness.cs | Captures marshalled ElementReference[] payloads from igSendMessage invocations. |
| tests/IgniteUI.Blazor.Tests/Interop/InteropHarness.cs | Extends InteropMethodCall with element-handle payloads. |
| tests/IgniteUI.Blazor.Tests/Interop/ComponentContract.cs | Adds render-sourced expectations (FromRender) and expected element-handle assertions to method specs. |
| tests/IgniteUI.Blazor.Tests/DropdownTests.cs | Adds contract-based tests for show/toggle target overloads using component and ElementReference anchors. |
| tests/IgniteUI.Blazor.Tests/ComponentWithContractTestBase.cs | Resolves render-sourced expected args and asserts carried element handles in recorded invocations. |
| src/componentsBase/WebInputs/Dropdown.cs | Fixes toggle target overload dispatch and aligns return types/decoding for show/toggle target overloads. |
| skills/igniteui-blazor-lite-testing/references/interop-contracts.md | Documents new interop-contract authoring patterns for render-sourced args and element handles. |
Contributor
|
These are also some of the suppressed methods in bulk automation due to bugs: https://github.com/IgniteUI/igniteui-blazor/blob/master/tests/IgniteUI.Blazor.Lite.TestBed/componentsConfig.json#L121 |
MayaKirova
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #296, which is ported from old internal boards.
Found in #286, fixed separately here
Fix dropdown toggle overload call and return type of all target overloads, unit test setup & coverage
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
README.MDCHANGELOG.MDupdates for newly added functionalityCloses #