docs: WIP calendar resource strings - #291
Draft
damyanpetev wants to merge 1 commit into
Draft
Conversation
damyanpetev
added
📖 documentation
skrustev
reviewed
Aug 4, 2026
| partial void OnSelectMonthChanging(ref string newValue); | ||
|
|
||
| /// <summary> | ||
| /// Text for the accessible label of the header button that switches the calendar to the months view. |
Member
There was a problem hiding this comment.
Maybe more clear would be to say it is for the "accessibility attribute aria-label", since label might mean something that's visible?
Same for SelectYear.
| partial void OnPreviousMonthChanging(ref string newValue); | ||
|
|
||
| /// <summary> | ||
| /// The label of the navigation button that moves the days view one month back. |
Member
There was a problem hiding this comment.
Also "aria-lable" related.
Same for NextMonth, PreviousYear, NextYear, PreviousYears, NextYears.
| partial void OnSelectDateChanging(ref string newValue); | ||
|
|
||
| /// <summary> | ||
| /// Title shown in the calendar header until a date is selected, in single selection mode. |
Member
There was a problem hiding this comment.
So we decide on this to be the correct functionality, since currently it is always showing Select Date/Select Range? Probably should log it?
Member
Author
There was a problem hiding this comment.
I have not, which is why this is WIP and I've no idea what to do with those props yet. Kinda why I tucked this PR to the side since we need to clear what's the functionality behind these, if any
damyanpetev
force-pushed
the
dpetev/xml-docs-calendar-resources
branch
from
August 6, 2026 07:25
d402873 to
7992c4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addition to #286 for the calendar resource strings, since those need to be reviewed specially and/or updated.
Type of Change (check all that apply):
Checklist:
README.MDCHANGELOG.MDupdates for newly added functionality