chore: remove orphaned CalendarDate and CalendarDateEventArgs - #310
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the orphaned IgbCalendarDate and IgbCalendarDateEventArgs types (and their marshal-by-value registrations) from the Ignite UI for Blazor library, reducing unused public surface area and keeping the interop type maps in sync with actual component usage.
Changes:
- Removed
IgbCalendarDateandIgbCalendarDateEventArgssource files from the Blazor wrappers. - Deleted
CalendarDatefrom the TypeScriptmarshalByValueSetused by the interop loader. - Deleted
CalendarDatehandling from the C# marshal-by-value factory (MustMarshalByValueandCreateInstance).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/src/Loader.ts |
Removes CalendarDate from the JS/TS marshal-by-value registration set. |
src/componentsBase/MarshalByValueFactory.cs |
Removes CalendarDate from C# marshal-by-value checks and instance creation. |
src/components/Blazor/CalendarDateEventArgs.cs |
Deletes the unused IgbCalendarDateEventArgs wrapper type. |
src/components/Blazor/CalendarDate.cs |
Deletes the unused IgbCalendarDate wrapper type. |
damyanpetev
enabled auto-merge (squash)
August 5, 2026 07:43
MayaKirova
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Found in #286 ; The CalendarDate and matching event args have no external references (i.e. not used for any of the components) and are likely an artifact of an older state generation and/or merely a static leftover that's not relevant anymore.
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
README.MDCHANGELOG.MDupdates for newly added functionalityCloses #