Skip to content

chore: remove orphaned CalendarDate and CalendarDateEventArgs - #310

Merged
damyanpetev merged 2 commits into
masterfrom
dpetev/remove-orphaned-calendardate
Aug 6, 2026
Merged

chore: remove orphaned CalendarDate and CalendarDateEventArgs#310
damyanpetev merged 2 commits into
masterfrom
dpetev/remove-orphaned-calendardate

Conversation

@damyanpetev

Copy link
Copy Markdown
Member

Description

Found in #286 ; The CalendarDate and matching event args have no external references (i.e. not used for any of the components) and are likely an artifact of an older state generation and/or merely a static leftover that's not relevant anymore.

Type of Change (check all that apply):

  • Bug fix
  • New functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes)
  • Documentation
  • Demos
  • CI/CD
  • Tests
  • Changelog

Component(s) / Area(s) Affected:

How Has This Been Tested?

  • Unit tests
  • Manual testing
  • Automated e2e tests

Test Configuration:

  • .NET version:
  • Hosting model:
  • Browser(s):
  • OS:

Screenshots / Recordings

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code
  • This PR includes API docs for newly added methods/properties
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes behavioral changes and the feature specification has been updated with them
  • Accessibility (ARIA, keyboard navigation, focus management) has been verified

Closes #

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the orphaned IgbCalendarDate and IgbCalendarDateEventArgs types (and their marshal-by-value registrations) from the Ignite UI for Blazor library, reducing unused public surface area and keeping the interop type maps in sync with actual component usage.

Changes:

  • Removed IgbCalendarDate and IgbCalendarDateEventArgs source files from the Blazor wrappers.
  • Deleted CalendarDate from the TypeScript marshalByValueSet used by the interop loader.
  • Deleted CalendarDate handling from the C# marshal-by-value factory (MustMarshalByValue and CreateInstance).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/src/Loader.ts Removes CalendarDate from the JS/TS marshal-by-value registration set.
src/componentsBase/MarshalByValueFactory.cs Removes CalendarDate from C# marshal-by-value checks and instance creation.
src/components/Blazor/CalendarDateEventArgs.cs Deletes the unused IgbCalendarDateEventArgs wrapper type.
src/components/Blazor/CalendarDate.cs Deletes the unused IgbCalendarDate wrapper type.

@damyanpetev
damyanpetev enabled auto-merge (squash) August 5, 2026 07:43
@damyanpetev
damyanpetev requested a review from dkamburov August 6, 2026 07:11
@damyanpetev
damyanpetev merged commit a200170 into master Aug 6, 2026
7 checks passed
@damyanpetev
damyanpetev deleted the dpetev/remove-orphaned-calendardate branch August 6, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants