feat: Added skeleton component - #2205
Draft
rkaraivanov wants to merge 5 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new Skeleton web component to the Ignite UI Web Components library, including its Storybook documentation, base styling, unit tests, and package exports so it can be consumed like the existing components.
Changes:
- Added
IgcSkeletonComponentimplementation with loading/animation behavior and measurement logic. - Added Storybook stories demonstrating common layouts and observer-driven remeasurement scenarios.
- Integrated the component into the public exports and
defineAllComponents()registration list, plus added base SCSS and unit tests.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| stories/skeleton.stories.ts | Adds Storybook coverage for the new skeleton component, including demos. |
| src/index.ts | Exposes IgcSkeletonComponent from the package entry point. |
| src/components/skeleton/themes/skeleton.base.scss | Introduces base SCSS for overlay/shapes and animation keyframes. |
| src/components/skeleton/skeleton.ts | Implements the new igc-skeleton component behavior and rendering. |
| src/components/skeleton/skeleton.spec.ts | Adds unit + accessibility tests for defaults, loading transitions, and animations. |
| src/components/common/definitions/defineAllComponents.ts | Registers the new component in the “define all” bundle. |
Comment on lines
+175
to
+179
| /** @internal */ | ||
| public override disconnectedCallback(): void { | ||
| super.disconnectedCallback(); | ||
| clearTimeout(this._revealTimeoutId); | ||
| } |
Comment on lines
+377
to
+384
| export const MutationObserverDemo: Story = { | ||
| argTypes: { | ||
| loading: {}, | ||
| animation: { | ||
| control: 'select', | ||
| options: ['pulse', 'breathe', 'shimmer', 'wave', 'glow'], | ||
| }, | ||
| }, |
Comment on lines
+143
to
+150
| constructor() { | ||
| super(); | ||
|
|
||
| addSlotController(this, { | ||
| slots: setSlots(), | ||
| onChange: this._scheduleMeasure, | ||
| }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist