Replace deprecated pynvml with nvidia-ml-py#27
Merged
Conversation
The profiling module imports pynvml but it was not declared as a dependency. The third-party pynvml package is deprecated and now just a shim over nvidia-ml-py. Using nvidia-ml-py directly avoids the FutureWarning while providing the same API. Closes #26 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
egrace479
approved these changes
Mar 30, 2026
NetZissou
added a commit
that referenced
this pull request
Mar 30, 2026
- Replace pynvml with nvidia-ml-py in pyproject.toml (aligns with PR #27) - Fix [yolo] -> [detection] optional extra in base_detector.py and all detection SLURM templates (5 files) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nvidia-ml-py>=11.5.0as a core dependency inpyproject.tomlsrc/hpc_inference/utils/profiling.py) importspynvmlbut it was never declared as a dependency onmainpynvmlPyPI package is deprecated — it's now a shim that installsnvidia-ml-pyand emits aFutureWarningon every importnvidia-ml-pydirectly provides the sameimport pynvmlAPI with no warningsNote for open PRs
PR #16 (
feature/detection) addedpynvml>=11.5.0to dependencies. After this PR merges, #16 should rebase and update its dependency tonvidia-ml-py>=11.5.0instead.Closes #26
🤖 Generated with Claude Code