Add force flags for non-interactive overwrite - #46
Closed
thompsonmj wants to merge 4 commits into
Closed
Conversation
Refuse to overwrite an existing output file by default in both the library and the CLI, per the consensus on #11 (option 3): - get_checksums gains force=False and raises OutputFileExistsError (subclass of FileExistsError) before any walking or hashing when the output file exists - CLI replaces the interactive overwrite prompt with -f/--force and a clear error message, making all runs non-interactive Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
Again, closed because this was opened automatically by Claude in testing Fable 5. I'm thinking some explicit instructions are needed in an AGENTS.md file ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
Implements option 3 from the issue discussion: refuse to overwrite an existing output file by default, in both the CLI and the library.
get_checksumsgainsforce=Falseand raisessumbuddy.exceptions.OutputFileExistsError(aFileExistsErrorsubclass) before any walking or hashing when the output file exists, leaving the file untouched.-f/--forceand a clear error message (exit code 1), so runs are never interactive.gather_file_pathsis called, the existing file is preserved,force=Trueregenerates output matching thedefault.csvfixture, the CLI exits without prompting, and both flag spellings overwrite end to end.Breaking change: library callers writing to an existing output file previously overwrote silently and now get
OutputFileExistsErrorunless they passforce=True. Slated for 2.0.0, with the version bump deferred to a release-prep PR per repo convention. After release, cautious-robot needsforce=Trueat itsget_checksumscall site and asum-buddy>=2.0.0pin; until then its broadexceptwould silently skip checksumming when a checksum CSV already exists.Verification:
pytest -rsgives 87 passed, 5 skipped (pre-existing algorithm-availability skips);ruff check .findings are identical tomain(pre-existing only); manual CLI checks confirm first write succeeds, rerun refuses with no prompt, and--forceoverwrites.