Add control over overwrites for non-interactive use - #47
Merged
Conversation
Refuse to overwrite an existing output file by default in both the library and the CLI, per the consensus on #11 (option 3): - get_checksums gains force=False and raises OutputFileExistsError (subclass of FileExistsError) before any walking or hashing when the output file exists - CLI replaces the interactive overwrite prompt with -f/--force and a clear error message, making all runs non-interactive Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
I'll also make a note here that a portion of the changes in this PR were due to the version bump of Ruff to 0.16. Since our CI depends on After merging this however, I'll open a few issues dedicated to addressing this for preempting future similar surprises and working with the linter in with more controlled approach, per offline discussion with @egrace479. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #11, using the approach outlined in option number three from this comment.
force=Trueand-f/--force)cautious-robotnecessary at an upstream arg or directly here.