Skip to content

Align analyzer/docs behavior and remove stale IAPI0010 remnants - #324

Merged
viceroypenguin merged 1 commit into
mainfrom
copilot/fix-issues-319-321-323
Jul 27, 2026
Merged

Align analyzer/docs behavior and remove stale IAPI0010 remnants#324
viceroypenguin merged 1 commit into
mainfrom
copilot/fix-issues-319-321-323

Conversation

Copilot AI commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

This PR resolves three small but user-facing consistency issues: a misleading CustomizeGroup diagnostic message, stale IAPI0010 leftovers after rule removal, and README wording that omitted PATCH from default body-binding verbs. The changes keep analyzer output, docs, and source-of-truth constants/tests in sync.

  • Analyzer message correction (IAPI0011)

    • Updated CustomizeGroupUsageAnalyzer message text to reference the correct required signature for CustomizeGroup.
  • Removed dead IAPI0010 artifacts

    • Deleted unused IAPI0010InvalidRouteGroupName from DiagnosticIds.
    • Removed orphaned ValidRouteGroupNames / InvalidRouteGroupNames theory data from test utility code.
  • README verb coverage fix

    • Updated AsParameters docs to state default [FromBody] behavior applies to POST, PUT, and PATCH.
messageFormat: "`CustomizeGroup` must be `private static void CustomizeGroup(RouteGroupBuilder group)`",

Copilot AI changed the title Fix issues #319, #321, and #323 Align analyzer/docs behavior and remove stale IAPI0010 remnants Jul 27, 2026
Copilot AI requested a review from viceroypenguin July 27, 2026 23:33
@viceroypenguin
viceroypenguin marked this pull request as ready for review July 27, 2026 23:40
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 30314506736

Coverage increased (+4.5%) to 96.26%

Details

  • Coverage increased (+4.5%) from the base build.
  • Patch coverage: 1 of 1 lines across 1 file are fully covered (100%).
  • 7 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

7 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
src/Common/ITypeSymbolExtensions.cs 5 97.57%
src/Common/AttributeDataExtensions.cs 2 93.88%

Coverage Stats

Coverage Status
Relevant Lines: 1444
Covered Lines: 1390
Line Coverage: 96.26%
Coverage Strength: 3.85 hits per line

💛 - Coveralls

@viceroypenguin
viceroypenguin merged commit e752e66 into main Jul 27, 2026
2 checks passed
@viceroypenguin
viceroypenguin deleted the copilot/fix-issues-319-321-323 branch July 27, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants